Opened 7 years ago

Closed 7 years ago

#5290 closed defect (fixed)

libvdpau-va-gl unnecessary circular dependency

Reported by: Pierre Labastie Owned by: bdubbs@…
Priority: normal Milestone: 7.6
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

libvdpau-va-gl requires both libva and gl from mesalib. But libva requires mesalib and mesalib requires libvdpau to build the VDPAU drivers.

So I have added libva as a dependency to libvdpau-va-gl.

Now since libvdpau-va-gl is on the same page as libvdpau, this creates a circular dependency.

The normal way out of this issue would be to split the page between libvdpau and libvdpau-va-gl, with the deps chain:
libvdpau-va-gl -> libva -> mesalib -> libvdpau

Since I have no way to test that it works (no intel hardware), I leave this ticket to people owning the hardware.

Change History (9)

comment:1 by Pierre Labastie, 7 years ago

Found another dependency on glu, added at r13546. This one also depends on mesalib.

comment:2 by Armin K, 7 years ago

libvdpau-va-gl should be split from libvdpau page. It depends on ffmpeg, which depends on both libva and libvdpau (not required, but depends) and that could create another unnecessary circular dep.

comment:3 by Fernando de Oliveira, 7 years ago

Type: enhancementdefect

Pierre, I think this can be classified as defect. Please, undo, if you disagree

in reply to:  3 comment:4 by Pierre Labastie, 7 years ago

Replying to fo:

Pierre, I think this can be classified as defect. Please, undo, if you disagree

I totally agree. Just forgot to consider that...

comment:5 by bdubbs@…, 7 years ago

I'm not sure about the dependency chain. When I added libvdpau-va-gl I did have the others, but I'm not sure about the circular part. Looking at my log, this is the order I built:

Mon May 12 22:10:22 CDT 2014 /usr/src/mesalib/MesaLib-10.1.3.tar.bz2

Tue May 13 00:17:48 CDT 2014 /usr/src/xc/drivers/libva-1.3.0.tar.bz2
Tue May 13 12:43:38 CDT 2014 /usr/src/xc/drivers/libva-1.3.1.tar.bz2
Tue May 13 12:44:12 CDT 2014 /usr/src/xc/drivers/libva-intel-driver-1.3.1.tar.bz2

Wed May 21 15:24:42 CDT 2014 /usr/src/mesalib/MesaLib-10.1.4.tar.bz2

Wed Jun  4 22:54:16 CDT 2014 /usr/src/ffmpeg/ffmpeg-2.2.3.tar.bz2

Mon Jun 16 11:30:40 CDT 2014 /usr/src/xc/drivers/libva-intel-driver-1.3.2.tar.bz2
Mon Jun 16 12:16:02 CDT 2014 /usr/src/xc/drivers/libva-intel-driver-1.3.2.tar.bz2

Sun Jul  6 22:37:49 CDT 2014 /usr/src/xc/drivers/libvdpau-0.8.tar.gz
Fri Jul 11 13:27:03 CDT 2014 /usr/src/xc/drivers/libvdpau-va-gl-0.3.4.tar.gz

libvdpau was not needed for me to build MesaLib and the order above worked at least for xine.

As best I can tell, libva-1.3.1 and libvdpau-0.8 are only runtime dependencies of ffmpeg, so the order is not significant there.

comment:6 by Pierre Labastie, 7 years ago

Summary: libvdpau-va-gl circular dependencylibvdpau-va-gl unnecessary circular dependency

I think libvdpau is only needed for mesalib to build the VDPAU drivers. If you do not need them you do not need libvdpau for mesalib. The real deps of libvdpau-va-gl are:

  • glu (needs mesalib)
  • libva (needs mesalib)
  • ffmpeg (for libswscale)
  • libvdpau (of course)

OTOH, I think the main point here is to split the page to avoid an artificial circular dep in the book.

comment:7 by bdubbs@…, 7 years ago

OK, I think I see what you mean. The page as is exists now implies building both libvdpau and libvdpau-va-gl at the same time. We (may) need to build libvdpau before mesalib and libvdpau-va-gl after mesalib. Is that the issue?

comment:8 by bdubbs@…, 7 years ago

Owner: changed from blfs-book@… to bdubbs@…
Status: newassigned

comment:9 by bdubbs@…, 7 years ago

Resolution: fixed
Status: assignedclosed

Fixed at revision 13697.

Note: See TracTickets for help on using tickets.