Opened 10 years ago

Closed 10 years ago

#5829 closed enhancement (fixed)

firefox-34.0.5

Reported by: Fernando de Oliveira Owned by: Fernando de Oliveira
Priority: normal Milestone: 7.7
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by Fernando de Oliveira)

​ftp://ftp.mozilla.org/pub/firefox/releases/34.0.5/source/firefox-34.0.5.source.tar.bz2

Change History (9)

comment:1 by Fernando de Oliveira, 10 years ago

I think we don't need this, but wait for comments, before close as wontfix.

comment:2 by Fernando de Oliveira, 10 years ago

Resolution: → wontfix
Status: new → closed

comment:3 by Fernando de Oliveira, 10 years ago

Milestone: 7.7 → hold
Resolution: wontfix
Status: closed → reopened

comment:4 by Fernando de Oliveira, 10 years ago

Summary: firefox-3.1.1 → firefox-3.1.1 (placeholder)

comment:5 by Armin K, 10 years ago

Summary: firefox-3.1.1 (placeholder) → firefox-33.1.1 (placeholder)

comment:6 by Fernando de Oliveira, 10 years ago

Description: modified (diff)
Milestone: hold → 7.7
Owner: changed from blfs-book@… to Fernando de Oliveira
Status: reopened → new
Summary: firefox-33.1.1 (placeholder) → firefox-34.0.5

comment:7 by Fernando de Oliveira, 10 years ago

I believe I found the place where MOZ_MAKE_FLAGS is filtered. 

$ grep -r MOZ_MAKE_FLAGS browser/
browser/config/mozconfigs/whitelist:        'mk_add_options MOZ_MAKE_FLAGS="-j4"',
browser/config/mozconfigs/whitelist:    'mk_add_options MOZ_MAKE_FLAGS="-j12"',
browser/config/mozconfigs/whitelist:    'mk_add_options MOZ_MAKE_FLAGS=-j1',
browser/config/mozconfigs/whitelist:        'mk_add_options MOZ_MAKE_FLAGS="-j4"',

To get the older behavior, as suggested by Pierre: 

mv -vi browser/config/mozconfigs/whitelist{,.orig}

I started and stopped a test, just to find that, using in mozconfig: 

mk_add_options MOZ_MAKE_FLAGS="-j$(getconf _NPROCESSORS_ONLN)"

The result was the expected one: 

$ grep "make -j" make.log
make -j8 -C /home/fernando/tmp/porg-build-2014.12.01-14h37m01s/mozilla-release/firefox-build-dir

which is correct for this machine and was not possible, because it was not in the whitelist.

Seems the day is becoming better.

comment:8 by Fernando de Oliveira, 10 years ago

Sorry, false alarm. It using -j8 no matter the value I try to use, as the first bad version did.

comment:9 by Fernando de Oliveira, 10 years ago

Resolution: → fixed
Status: new → closed

Fixed at r15105.

Note: See TracTickets for help on using tickets.