Opened 9 years ago

Closed 9 years ago

#5920 closed enhancement (fixed)

speex-1.2rc2

Reported by: bdubbs@… Owned by: bdubbs@…
Priority: normal Milestone: 7.7
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

Interesting. rc1 was released 24-Jul-2008 and rc2 on 6-Dec-2014.

They moved from svn to git and changed a lot of build tools including a lot of copyright changes, but I couldn't find any list of changes. The changelog is still from 2005.

libspeexdsp.so is no longer built or installed, but I did see speexdsp-1.2rc2.tar.gz package at the upstream source directory. speex is mentioned in 9 BLFS packages, but I have not idea if libspeexdsp is used or not.

Change History (25)

comment:1 by Armin K, 9 years ago

The following files on my system are linked to libspeexdsp.so.1 from speex-1.2rc1 at the moment:

/usr/bin/speexenc (speex-1.2rc1)

/usr/lib/alsa-lib/libasound_module_rate_speexrate.so (alsa-plugins)
/usr/lib/alsa-lib/libasound_module_pcm_speex.so (alsa-plugins)
/usr/lib32/alsa-lib/libasound_module_rate_speexrate.so (alsa-plugins)
/usr/lib32/alsa-lib/libasound_module_pcm_speex.so (alsa-plugins)

/usr/lib/libpulsecore-5.99.so (pulseaudio)
/usr/lib/pulse/modules/module-echo-cancel.so (pulseaudio)

/usr/lib/vlc/plugins/audio_filter/libspeex_resampler_plugin.so (vlc)

The following packages in the trunk reference speex package:

xsoft/other/gnash.xml:      <xref linkend="speex"/>, (*)
multimedia/libdriv/alsa-plugins.xml:      <xref linkend="speex"/>
multimedia/libdriv/gst-plugins-good.xml:      <xref linkend="speex"/>,
multimedia/libdriv/xine-lib.xml:      <xref linkend="speex"/>,
multimedia/libdriv/gst10-plugins-good.xml:      <xref linkend="speex"/>,
multimedia/libdriv/pulseaudio.xml:      <xref linkend="speex"/> and
multimedia/libdriv/opal.xml:      <xref linkend="speex"/>, and (*)
multimedia/audioutils/vorbistools.xml:      <xref linkend="speex"/> (*)
multimedia/videoutils/vlc.xml:      <xref linkend="speex"/>,
multimedia/videoutils/ffmpeg.xml:      <xref linkend="speex"/>,
multimedia/videoutils/mplayer.xml:      <xref linkend="speex"/>, (*)

All of the packages that reference speex list it as an optional dependency. pulseaudio is the only one that lists it as a recommended dependency.

The ones marked with (*) are the packages that I *don't* have installed on my system. I could possibly do a quick check for mplayer (I use mpv nowadays), vorbis-tools and opal. I don't want to build gnash though, so I'll leave that to someone else.

comment:2 by Armin K, 9 years ago

vorbis-tools and mplayer only use libspeex.so, not libspeexdsp.so. Gnash and Opal remain to be checked and I don't have the time to build any of them.

comment:3 by Fernando de Oliveira, 9 years ago

Thank you very much, Armin. I will test them, to add to the check list you did.

However, after what you wrote, I think we should not do the update. Is this understanding correct?

comment:4 by Armin K, 9 years ago

I think it should be fine. What remains to be discussed is will speexdsp be added to the book or referenced as an external package when the update happens since it isn't a hard dep for anything. I'm for adding it, since speex wasn't a hard dep for anything, yet it was there all the time.

comment:5 by Fernando de Oliveira, 9 years ago

OK. Linked to libspeexdsp.so.1:

/usr/lib/libopal.so (opal-3.10.10)

gnash-0.8.10 only links to /usr/lib/libspeex.so.1

Now, I'll check the "new package to be" speexdsp-1.2rc2.tar.gz.

comment:6 by Armin K, 9 years ago

speexdsp-1.2rc2 fails to build due to a missing header in the tarball. Added a patch to the patches repository.

comment:7 by Fernando de Oliveira, 9 years ago

Didn't fail here. Have just installed it.

What is the error?

comment:8 by Fernando de Oliveira, 9 years ago

Ok, confirmed the need of the patch, after removed the header.

comment:9 by Fernando de Oliveira, 9 years ago

But shouldn't it be installed as /usr/include/speex/speex_buffer.h?

comment:10 by Armin K, 9 years ago

No. It would be installed by default.

comment:11 by Fernando de Oliveira, 9 years ago

Here, it doesn't get installed:

$ ls -l /usr/include/speex/
total 100
-rw-r--r-- 1 root root  6660 Dez  7 13:59 speex_bits.h
-rw-r--r-- 1 root root  5033 Dez  7 13:59 speex_callbacks.h
-rw-r--r-- 1 root root   203 Dez  7 13:59 speex_config_types.h
-rw-r--r-- 1 root root   348 Dez  7 13:59 speexdsp_config_types.h
-rw-r--r-- 1 root root  3592 Dez  7 13:59 speexdsp_types.h
-rw-r--r-- 1 root root  6450 Dez  7 13:59 speex_echo.h
-rw-r--r-- 1 root root 14030 Dez  7 13:59 speex.h
-rw-r--r-- 1 root root  4084 Dez  7 13:59 speex_header.h
-rw-r--r-- 1 root root  7216 Dez  7 13:59 speex_jitter.h
-rw-r--r-- 1 root root  8606 Dez  7 13:59 speex_preprocess.h
-rw-r--r-- 1 root root 14728 Dez  7 13:59 speex_resampler.h
-rw-r--r-- 1 root root  3675 Dez  7 13:59 speex_stereo.h
-rw-r--r-- 1 root root  3582 Dez  7 13:59 speex_types.h

comment:12 by Armin K, 9 years ago

What I meant is: "No. It would be installed by default if it was to be installed."

Short: It should not be installed, it's a private header.

comment:13 by Fernando de Oliveira, 9 years ago

But it was before, in the version of the book.

It is not listed to be installed in the Makefile list of headers to be installed.

I got it installed using, after configure is run:

sed -i 's/speexdsp_types.h/& speex_buffer.h/' include/speex/Makefile

comment:15 by bdubbs@…, 9 years ago

I think that perhaps we should add speexdsp-1.2rc2.tar.gz as an additional download for speex and build it on the same page as speex. What do you think?

comment:16 by Armin K, 9 years ago

I'm for it. But, these two packages are not dependent on each other, so it may be impractical. We also had Mesa and GLU on one page but had to split that because someone complained (not sure who, can't remember).

comment:17 by bdubbs@…, 9 years ago

They may be independent, but I suspect that they would never actually be released independently.

in reply to:  14 comment:18 by Fernando de Oliveira, 9 years ago

Replying to Krejzi:

Upstream decided it's not needed.

https://github.com/xiph/speexdsp/commit/ac91846ffae99867bbf076a9e3f0d01276d47646

Thanks. I tried to navigate in and clone their git, earlier, but was not allowed:

http://git.xiph.org/

Forbidden

You don't have permission to access / on this server.

Having that address you gave is good. Thanks, again.

comment:19 by Armin K, 9 years ago

Yeah, that's why I looked for an alternative mirror and found it on github. I needed to get the header file from somewhere.

in reply to:  17 comment:20 by Fernando de Oliveira, 9 years ago

Replying to bdubbs@…:

They may be independent, but I suspect that they would never actually be released independently.

Replying to bdubbs@…:

They may be independent, but I suspect that they would never actually be released independently.

I asked to split Mesa/GLU.

For this ticket I would agree with them in the same page. But it would be good some explanation, split in two parts, one in speex perhaps almost as is and another one explaning the use of the other one. In the GLU case there was no introduction for GLU, just the instructions.

comment:21 by Fernando de Oliveira, 9 years ago

Bruce, I could take this, but I would like to ask you or someone else to take it and also #5922.

comment:22 by Fernando de Oliveira, 9 years ago

Please.

comment:23 by Fernando de Oliveira, 9 years ago

Thanks again, Armin.

comment:24 by bdubbs@…, 9 years ago

Owner: changed from blfs-book@… to bdubbs@…
Status: newassigned

comment:25 by bdubbs@…, 9 years ago

Resolution: fixed
Status: assignedclosed

Fixed at revision 15198.

Note: See TracTickets for help on using tickets.