gnumeric-1.12.19

[bdubbs@…]

New point version

[Pierre Labastie]

hum. Looks like there are -Werror flags producing errors (gcc-4.9.2)

[Fernando de Oliveira]

Have not installed this version, so, I can't tell.

But IIRC, this is package depends on goffice and both are released together. If you look at the changelog (I just did for one update) they are sequentially updated: goffice, the gnumeric. I had problems sometime, trying to do in inverse order. An ex-editor taught me that.

Perhaps the errors will continue, perhaps not.

I really, really was not wanting to intrude, but it may be better you taking the other ticket too (goffice), do both in sequence. Well, in my age we forget quickly things and I ma write by memory, so I might be wrong.

Well, you may also just install new goffice, if you don't want to take that ticket.

Please, forgive my intrusion here.

[Fernando de Oliveira]

Hi again, Pierre,

I did write write as soon as took the ticket, because I knew you would figure it out and as I wrote above, I don't like to get in the way of the other devs.

Summary what follows is that your claim is correct and the solution is to install, first, goffice-0.10.19.

Notice that both packages point versions are equal and released always almost simultaneously.

But minutes ago I confirmed:

1. Make fails with goffice-0.10.18:

  CC       dialog-cell-sort.lo
dialog-cell-format.c: In function 'build_validation_error_combo':
dialog-cell-format.c:1833:4: error: implicit declaration of function 'go_gtk_widget_render_icon_pixbuf' [-Werror=implicit-function-declaration]
    ? go_gtk_widget_render_icon_pixbuf (GTK_WIDGET (wbcg_toplevel (state->wbcg)),
    ^
dialog-cell-format.c:1833:4: error: nested extern declaration of 'go_gtk_widget_render_icon_pixbuf' [-Werror=nested-externs]
dialog-cell-format.c:1835:4: warning: pointer/integer type mismatch in conditional expression
    : NULL;
    ^
  CC       dialog-col-width.lo
dialog-cell-sort.c: In function 'dialog_init':
dialog-cell-sort.c:1110:2: warning: 'gtk_button_set_alignment' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:143) [-Wdeprecated-declarations]
  gtk_button_set_alignment (GTK_BUTTON (state->up_button), 0., .5);
  ^
dialog-cell-sort.c:1111:2: warning: 'gtk_button_set_alignment' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:143) [-Wdeprecated-declarations]
  gtk_button_set_alignment (GTK_BUTTON (state->down_button), 0., .5);
  ^
dialog-cell-sort.c:1112:2: warning: 'gtk_button_set_alignment' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:143) [-Wdeprecated-declarations]
  gtk_button_set_alignment (GTK_BUTTON (state->add_button), 0., .5);
  ^
dialog-cell-sort.c:1113:2: warning: 'gtk_button_set_alignment' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:143) [-Wdeprecated-declarations]
  gtk_button_set_alignment (GTK_BUTTON (state->delete_button), 0., .5);
  ^
dialog-cell-sort.c:1114:2: warning: 'gtk_button_set_alignment' is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkbutton.h:143) [-Wdeprecated-declarations]
  gtk_button_set_alignment (GTK_BUTTON (state->clear_button), 0., .5);
  ^
dialog-cell-sort.c: In function 'dialog_cell_sort':
dialog-cell-sort.c:1173:3: error: implicit declaration of function 'go_gtk_widget_render_icon_pixbuf' [-Werror=implicit-function-declaration]
   go_gtk_widget_render_icon_pixbuf (state->dialog,
   ^
dialog-cell-sort.c:1173:3: error: nested extern declaration of 'go_gtk_widget_render_icon_pixbuf' [-Werror=nested-externs]
dialog-cell-sort.c:1172:25: warning: assignment makes pointer from integer without a cast
  state->image_ascending =
                         ^
dialog-cell-sort.c:1176:26: warning: assignment makes pointer from integer without a cast
  state->image_descending =
                          ^
  CC       dialog-col-row.lo
cc1: some warnings being treated as errors

But the errors are:

dialog-cell-format.c:1833:4: error: implicit declaration of function 'go_gtk_widget_render_icon_pixbuf' [-Werror=implicit-function-declaration]
...
dialog-cell-format.c:1833:4: error: nested extern declaration of 'go_gtk_widget_render_icon_pixbuf' [-Werror=nested-externs]
...
dialog-cell-sort.c:1173:3: error: implicit declaration of function 'go_gtk_widget_render_icon_pixbuf' [-Werror=implicit-function-declaration]
...
dialog-cell-sort.c:1173:3: error: nested extern declaration of 'go_gtk_widget_render_icon_pixbuf' [-Werror=nested-externs]
...
cc1: some warnings being treated as errors

Then, you're right: "warnings being treated as errors"

2. However, upgrade to goffice-0.10.19 solves the problem

As I wrote before, I blurred remembered having had the same problem.

Again, just trying to help. Please, if you don't like, tell me and I won't intrude again in the future.

[Pierre Labastie]

Thanks a lot Fernando. I have not had the time to look at this since my last comment, so you make my life much easier! I just accepted goffice's ticket too.

[Pierre Labastie]

Updating goffice allowed to build, but now, I have a problem with dependencies, I think: a lot of icons are missing in the taskbar, and I guess the reason is that no icon theme is installed. I tried to see where I missed that in the dependency tree, and it looks like an icon theme is nowhere recommended (nor required). I think an icon them should at least be recommended for gnumeric. Since I do not know much about those themes, what icon theme should I recommend?

[Pierre Labastie]

OK, this is development, so I'll add adwaita icon theme as recommended for gnumeric: if this is not what should be done, I'll be happy to revert or to recommend another theme, or whatever...

[Pierre Labastie]

Fixed at r15405.

[Fernando de Oliveira]

I have just finished testing probably all icon themes we have in BLFS. Gnumeric runs without messages in the terminal for Adwaita, Gnome and Oxygen icon themes.