Missing dependencies in polkit-qt

[ken@…]

Looking at what is actually needed to build some of kde, I have several times seen instructions which reference cmake, but do not include it as a dep. The example which caused me to flag this is polkit-qt.

Like many packages, this invokes cmake in the instructions but does not list it as a dependency. For some kde-ish packages you need to have cmake to build the dependencies, (e.g. polkit-kde-agent which depends on polkit-qt), but here I cannot see where cmake would be pulled in.

Also, we have -DUSE_QT4=TRUE with an explanation that this will force use of qt4 even if qt5 is present, but neither is listed as a dep and I'm not sure how that dependency should be worded.

[bdubbs@…]

We used to have automoc4 as a dependency for polkit-qt and that pulled in cmake and qt4. We removed automoc4 because it evidently is not strictly needed, especially if qt5 is being used.

Since polkit-qt is in the KDE instructions and the only packages that use polkit-qt is polkit-kde-agent and kdelibs, it is highly unlikely that polkit-qt would be built before cmake, qt, or automoc4.

Under these circumstances, I'll go ahead and add cmake and qt4 as required, but from a practical standpoint, it really doesn't make any difference.

[bdubbs@…]

Fixed at revision 15475.