Opened 11 years ago

Closed 11 years ago

#7369 closed enhancement (fixed)

Update to libpng-1.6.21 and replace apng patch

Reported by: Fernando de Oliveira Owned by: Fernando de Oliveira
Priority: normal Milestone: 7.9
Component: BOOK Version: SVN
Severity: medium Keywords:
Cc:

Description (last modified by Fernando de Oliveira)

http://downloads.sourceforge.net/libpng/libpng-1.6.21.tar.xz

http://downloads.sourceforge.net/libpng/libpng-1.6.21.tar.xz.asc New patch to be used replacing the old one:

http://downloads.sourceforge.net/project/apng/libpng/libpng16/libpng-1.6.21-apng.patch.gz

http://sourceforge.net/p/png-mng/mailman/png-mng-announce/?viewmonth=201601

or

http://sourceforge.net/p/png-mng/mailman/message/34770176/

[png-mng-announce] libpng-1.6.21 is available
From: Glenn Randers-Pehrson <glennrp@gm...> - 2016-01-15 20:35:15
Attachments: Message as HTML    

...

Changes since the last public release (1.6.20):

• Fixed syntax "$(command)" in tests/pngstest that some shells other
  than bash could not parse (Bug report by Nelson Beebe). Use `command`
  instead.
• Moved png_check_keyword() from pngwutil.c to pngset.c
• Removed LE/BE dependencies in pngvalid, to 'fix' the current problem
  in the BigEndian tests by not testing it, making the BE code the same
  as the LE version.
• Fixes to pngvalid for various reduced build configurations (eliminate
  unused statics) and a fix for the case in rgb_to_gray when the
  digitize option reduces graylo to 0, producing a large error.
• Widened the 'limit' check on the internally calculated error limits in
  the 'DIGITIZE' case (the code used prior to 1.7 for rgb_to_gray error
  checks) and changed the check to only operate in non-release builds
  (base build type not RC or RELEASE.)
• Fixed undefined behavior in pngvalid.c, undefined because (png_byte)
  << shift is undefined if it changes the signed bit (because png_byte
  is promoted to int). The libpng exported functions png_get_uint_32 and
  png_get_uint_16 handle this. (Bug reported by David Drysdale as a
  result of reports from UBSAN in clang 3.8).
• This changes pngvalid to use BE random numbers; this used to produce
  errors but these should not be fixed as a result of the previous
  changes.
• In projects/vstudio, combined readme.txt and WARNING into README.txt
• Relocated assert() in contrib/tools/pngfix.c, bug found by American
  Fuzzy Lop, reported by Brian Carpenter.
• Marked 'limit' UNUSED in transform_range_check().  This only affects
  release builds.
• Worked around a false-positive Coverity issue in pngvalid.c.

Glenn

Change History (8)

comment:1 by Fernando de Oliveira, 11 years ago

Owner: changed from blfs-book@… to Fernando de Oliveira
Status: newassigned

comment:2 by Fernando de Oliveira, 11 years ago

Patch not available yet.

comment:3 by Fernando de Oliveira, 11 years ago

Still, new patch.

in reply to:  3 comment:4 by Fernando de Oliveira, 11 years ago

Replying to fo:

Still, new patch.

Should read:

Still, no new patch.

comment:5 by Fernando de Oliveira, 11 years ago

I am studying (again, done that in the past, but gave up)libpng-1.6.21-apng.patch.gz (actually, version 1.6.20) from

http://sourceforge.net/projects/apng/files/libpng/libpng16/libpng-1.6.21-apng.patch.gz/download

and comparing to the one used in BLFS.

Reason is that they are always available simultaneously (or quite so) with the corresponding libpng.

comment:6 by Fernando de Oliveira, 11 years ago

OK, apparently works at all stages.

In MiniBrowser, from visual inspection of apng image, it works correctly, and checked it is using the new installed libpng-1.6.21.

Didn't complete Firefox build, but it gets acTL:

...
checking for png_get_acTL in -lpng... yes
...

Will replace definitely that patch, comment out the old one, just in case we have any problem in the future, unless there is any objection.

comment:7 by Fernando de Oliveira, 11 years ago

Description: modified (diff)
Summary: libpng-1.6.21Update to libpng-1.6.21 and replace apng patch

comment:8 by Fernando de Oliveira, 11 years ago

Resolution: fixed
Status: assignedclosed

Fixed at r16830.

Note: See TracTickets for help on using tickets.