Opened 6 years ago

Closed 6 years ago

#7967 closed defect (fixed)

cdrdao-1.2.3 fails to build with gcc-6.1

Reported by: ken@… Owned by: ken@…
Priority: normal Milestone: 7.10
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

CdrDriver.cc:498:64: error: narrowing conversion of '255' from 'int' to 'char' inside { } [-Wnarrowing]
 char CdrDriver::REMOTE_MSG_SYNC_[4] = { 0xff, 0x00, 0xff, 0x00 };
                                                                ^

I see that gentoo apparently hit this in gcc-5.3, but fedora have a slightly bigger change (header as well as the cc file) for gcc-6.

I'm testing a sed but I won't be in a position to do a runtime test until I've built xfburn - that might be days away, depending what else breaks and how things go with debugging asymptote for texlive.

The new build fix is

sed -i 's/\(char .*REMOTE\)/unsigned \1/' dao/CdrDriver.{cc,h}

Also, I propose to remove lingering references to gcdmaster which needs a stack of gnome2 dependencies.

Change History (3)

comment:1 by ken@…, 6 years ago

Owner: changed from blfs-book@… to ken@…
Status: newassigned
Type: enhancementdefect

comment:2 by ken@…, 6 years ago

Fixed in r17509

comment:3 by ken@…, 6 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.