Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#9015 closed defect (fixed)

libwww-perl : missing test dependency

Reported by: ken@… Owned by: blfs-book@…
Priority: normal Milestone: 8.1
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by ken@…)

Somewhere between versions 6.20 and 6.23 this developed a need for Test-RequiresInternet to run its testsuite. At least that is a trivial dependency, only needing core modules.

Change History (8)

comment:1 by ken@…, 5 years ago

Description: modified (diff)

I mistyped the version - I noticed this on 6.23.

Meanwhile, the book has moved on to 6.24, but that retains the dep:

  "TEST_REQUIRES" => {
    "ExtUtils::MakeMaker" => 0,
    "File::Spec" => 0,
    "FindBin" => 0,
    "Test::Fatal" => 0,
    "Test::More" => 0,
    "Test::RequiresInternet" => 0
  },
  "VERSION" => "6.24",

comment:2 by bdubbs@…, 5 years ago

I don't understand what you want done. There are several modules above that we do not mention: ExtUtils::MakeMaker, File::Spec, FindBin, and Test::More" as well as Test::RequiresInternet

Do we really need to specify every module a parent uses for a test?

I personally do not see any issues with the tests as I use the 'cpan -i ' method of installing a module and it automatically pulls in needed modules whether for the module requested or for tests.

comment:3 by ken@…, 5 years ago

If people want to pull in *all* the *possible* dependent modules using cpan -i, they can run a distro. But in that case we might as well tell everybody to just use cpan, and point them to the latest version (which is what it normally uses).

Of the modules you mentioned, ExtUtils::MakeMaker, File::Spec, FindBin and Test::More are core modules, which I documented in general/prog/perl-core-modules.txt.

My point is that for anybody whole builds modules individually, the tests are almost-always expected to pass. A run of 'make test' in a perl module which ends in failure implies a real problem, unlike for many packages where testsuites are often likely to fail.

Some of those failures are because of missing runtime dependencies, which are clearly needed. Others, like this example, are only important to stop the testsuite failing.

Third paragraph of the page -

Where a module is shown as '(for the testsuite)' it is required if you wish to run the test for the module which uses it. In these cases, only the required or recommended dependencies are listed - there might be other modules which allow more tests to be run, but omitting them will still allow the tests to PASS.

So, I think that Test::RequiresInternet should be added for libwww-perl in the same way that e.g. SUPER was added for Test::MockModule in the deps of Archive::Zip.

comment:4 by bdubbs@…, 5 years ago

Oh, I don't object to adding it. I was saying that I didn't understand what was asked.

Do you want to do it? It sounds like it would be a quick update.

in reply to:  4 comment:5 by ken@…, 5 years ago

Replying to bdubbs@…:

Oh, I don't object to adding it. I was saying that I didn't understand what was asked.

Do you want to do it? It sounds like it would be a quick update.

I still find editing that page to add new dependencies tends to be painful. At the moment I have no wish to touch it.

comment:6 by bdubbs@…, 5 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 18514.

comment:7 by bdubbs@…, 5 years ago

Milestone: 8.1m8.1

Milestone renamed

comment:8 by bdubbs@…, 5 years ago

Milestone: m8.18.1

Milestone renamed

Note: See TracTickets for help on using tickets.