gptfdisk-1.0.1 does not install sgdisk

[Wayne Blaszczyk]

Having all the optional dependencies installed (popt and icu), sgdisk is not installed.

[Wayne Blaszczyk]

Arch does not use make install.

​https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/gptfdisk

[bdubbs@…]

Hmm, did you use the gptfdisk convenience patch?

+ifdef POPT
+ EXTRA_LIBS += -lpopt
+ SGDISK      = sgdisk
+endif
...
+install: all
+  mkdir -p $(DESTDIR)/sbin $(DESTDIR)/usr/share/man/man8
+  cp gdisk cgdisk fixparts $(SGDISK) $(DESTDIR)/sbin
+  cp *.8 $(DESTDIR)/usr/share/man/man8

The patch is BLFS specific. I use the following to build:

patch -Np1 -i $DIR/$PROGRAM-convenience-1.patch  &&
make ICU=0 POPT=1
sudo make POPT=1 install

Look at the command explanations on the page.

[Wayne Blaszczyk]

I did use the patch, however I did not set the variables as I did not read the Command Explanation section. I usually don't ready the Command Explanation section unless there is a command in the Installation section that I would like find out more about why we are using the command/option.

I feel it would be beneficial if the option was mentioned in the Installation section?

[bdubbs@…]

Upgrades popt to a recommended dependency. Changed build instructions to build/install sgdisk by default.

Fixed at revision 18871.