Opened 4 years ago

Closed 4 years ago

#9616 closed defect (fixed)

GPM patch for glibc-2.26/gcc-7.2.0

Reported by: Douglas R. Reno Owned by: Pierre Labastie
Priority: normal Milestone: 8.1
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

I've had two people who were trying GPM report this issue to me, and upon scouting upstream, I found an issue by our very own 'tnut':

https://github.com/telmich/gpm/issues/21

gcc -I. -I/tmp/work/src/gpm/src -DHAVE_CONFIG_H -include headers/config.h -Wall -DSYSCONFDIR=""/etc"" -DSBINDIR=""/usr/sbin"" -D_GNU_SOURCE -O2 -pipe -O2 -pipe -c -o prog/gpm-root.o prog/gpm-root.c
/tmp/work/src/gpm/src/prog/gpm-root.y: In function 'postmenu':
/tmp/work/src/gpm/src/prog/gpm-root.y:1030:32: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
#define PUTS(s,f,b) for(curr2=s;curr2;PUTC((curr2++),f,b))
^
/tmp/work/src/gpm/src/prog/gpm-root.y:1045:10: note: in expansion of macro 'PUTS'
PUTS(draw->title,draw->head,draw->back);
^~~~
/tmp/work/src/gpm/src/prog/gpm-root.y:1030:32: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
#define PUTS(s,f,b) for(curr2=s;curr2;PUTC((curr2++),f,b))
^
/tmp/work/src/gpm/src/prog/gpm-root.y:1053:10: note: in expansion of macro 'PUTS'
PUTS(item->name,draw->fore,draw->back); i+=strlen(item->name);
^~~~
/tmp/work/src/gpm/src/prog/gpm-root.y: In function 'main':
/tmp/work/src/gpm/src/prog/gpm-root.y:1200:4: warning: implicit declaration of function '__sigemptyset'; did you mean 'sigemptyset'? [-Wimplicit-function-declaration]
__sigemptyset(&childaction.sa_mask);
^~~~~~~~~~~~~
sigemptyset
gcc -L/tmp/work/src/gpm/src -lm -o prog/gpm-root prog/gpm-root.o lib/libgpm.so.2
prog/gpm-root.o: In function main': gpm-root.c:(.text.startup+0x1fe): undefined reference to__sigemptyset'

Try tnut's patch here, and adapt:

http://downloads.nutyx.org/x86_64/development/base/gpm/gpm-1.20.7-glibc-2.26-1.patch

Change History (5)

comment:1 by Pierre Labastie, 4 years ago

Seems that sed -i s/__sigemptyset/sigemptyset/ src/prog/gpm-root.y and sed -i s/__sigemptyset/sigemptyset/ src/daemon/openconsole.c could do. See Riccardo Corsi's mail. But tnut's patch is more complicated. I'll try soon...

in reply to:  1 comment:2 by Pierre Labastie, 4 years ago

Replying to pierre.labastie:

Seems that sed -i s/__sigemptyset/sigemptyset/ src/prog/gpm-root.y and sed -i s/__sigemptyset/sigemptyset/ src/daemon/openconsole.c could do.

This is not enough... The patch allows to build.

comment:3 by Pierre Labastie, 4 years ago

Owner: changed from blfs-book@… to Pierre Labastie
Status: newassigned

comment:4 by Pierre Labastie, 4 years ago

With the patch, gpm is built and runs OK.

Last edited 4 years ago by Pierre Labastie (previous) (diff)

comment:5 by Pierre Labastie, 4 years ago

Resolution: fixed
Status: assignedclosed

Fixed at r19035

Note: See TracTickets for help on using tickets.