Opened 5 years ago

Closed 5 years ago

#9855 closed enhancement (fixed)

firefox-56.0.1

Reported by: bdubbs@… Owned by: ken@…
Priority: normal Milestone: 8.2
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description

New point version.

Change History (7)

comment:1 by ken@…, 5 years ago

At the moment, no release notes.

comment:2 by ken@…, 5 years ago

Owner: changed from blfs-book@… to ken@…
Status: newassigned

The source shows a difference in a test file (we disable the tests) and some changes in the code for windows. I was going to ignore this, but we update other packages when they only fix builds on non-linux.

I'll also give it a go without disabling tests (the description for --disable-tests is "do not build auxiliary applications to help debug and patch the mozilla source") in case that looks interesting (we've been doing that for years), I assume that might run tests automatically.

comment:3 by ken@…, 5 years ago

Upon my word, we have been economical with the actualité : there IS a testsuite (using gtest), but the details of how to run it were less than obvious and some mozilla posts.

First, remove --disable-tests : on 4 cores this adds about 3 SBU and 1.1G to the build - that space alone is enough reason not to do it for normal use. Second, to run the tests use './mach gtest'. This does some network activity and mostly runs single-threaded. It takes 6 SBU, has to be run from within X (I got a popup for a failed connection to alsa - alsa is disabled in the mozconfig), and finished by telling me I had 2 FAILED TESTS, TestUDPSocket.TestUDPSocketMain and Gfx.PingPongRegion (as well as 41 disabled tests, which are probably for other platforms).

<sigh/>Time to build with stylo instead of system libs, to compare the test results.

comment:4 by ken@…, 5 years ago

Delete 'and some mozilla posts' - I was originally going to say they were inaccurate, claiming that release builds disabled tests, but maybe they were right at some time in the past. Didn't delete the whole phrase before posting :-(

comment:5 by ken@…, 5 years ago

Make that +2.5GB for the tests, I forgot to remeasure after running them.

FWIW, if I enable stylo and drop the system libs, the build takes significantly longer and with the tests takes a further 0.8GB, and that TestUDPSocket test still fails.

comment:6 by ken@…, 5 years ago

The TestUDPSocket.TestUDPSocketMain test fails with a timeout.

The test of Gfx.PingPongRegion only fails with our build (i.e. disabling stylo), and all of its tests of ar.Region().IsEqual(r) return false instead of true. AFAICS that test, and the code it tests, has not changed in this point release, so I assume 56.0 would have failed similarly if I had known how to test it.

As with most testsuites, I doubt this is worth running - but since we cover how to run tests, I'll add the details.

comment:7 by ken@…, 5 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.