Opened 23 years ago

Closed 23 years ago

Last modified 23 years ago

#125 closed defect (fixed)

Simplify sed's

Reported by: gerard@… Owned by: markh@…
Priority: normal Milestone:
Component: Book Version: CVS
Severity: normal Keywords:
Cc:

Description

Proposed by Handy Hron:

In chapter 5 bzip2-1.0.1 is currently: sed \

s/"\$(CC) \$(CFLAGS) -o"/"\$(CC) \$(CFLAGS) \$(LDFLAGS) -o"/ \

proposed: sed \

's/$(CC) $(CFLAGS) -o/$(CC) $(CFLAGS) $(LDFLAGS) -o/' \

The other one in chapter 5 is Mawk. It uses the same sed as bzip2. In Chapter 6 there are a couple seds would be simpler if they used the

feature that: 's/' == 's
|' There is already a sed using this feature

in chapter 6 (Util-linux-2.11h)

glibc-2.2.3 currently:

sed s/"\$(PERL)"/"\/usr\/bin\/perl"/ \ ... sed s/"cross-compiling = yes"/"cross-compiling = no"/ \

proposed:

sed 's|$(PERL)|/usr/bin/perl|' \ ... sed 's/cross-compiling = yes/cross-compiling = no/ \

Procinfo-18 has double quotes. They could be switched to singles for consistancy. Util-linux-2.11h currently:

sed "s|etc/adjtime\"\$|var/lib/hwclock/adjtime\"|" \

proposed:

sed 's|etc/adjtime|var/lib/hwclock/adjtime|' \

Change History (2)

comment:1 by markh@…, 23 years ago

Owner: changed from lfs-book@… to markh@…
Status: newassigned

The bzip2 and mawk ones will probably be irrelevant now. I'll have a look at the others later on today to check them.

comment:2 by markh@…, 23 years ago

Resolution: fixed
Status: assignedclosed

These have all been checked and added to cvs where appropriate.

Note: See TracTickets for help on using tickets.