Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#1636 closed defect (fixed)

GCC shouldn't run `fixincludes' in pass2 or chapter 6

Reported by: Matthew Burgess Owned by: Matthew Burgess
Priority: normal Milestone:
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

See the above email for the start of the thread. Basically, from gcc-pass2 onwards we know that we have a set of modern system headers. If these need fixing they should be fixed in their respective package instructions, not by way of gcc's `fixincludes' script (whose heuristics have been shown to incorrectly apply fixes on occasion). We don't need to re-introduce the no_fixincludes patch though, the following `sed' should do it (from http://www.linuxfromscratch.org/pipermail/lfs-dev/2005-September/053517.html):

sed -i 's@$(SHELL) ./fixincl.sh@true@g' gcc/fixincludes/Makefile.in

Greg Schafer offered the alternative:

sed -i.bak 's,\./fixinc\.sh,-c true,' gcc/Makefile.in

Obviously when one of these go into the book, the '-i' will have to be replaced in chapter 5, as we can't rely on that parameter being supported on the host's sed.

Change History (4)

comment:1 by Matthew Burgess, 19 years ago

Owner: changed from lfs-book@… to Matthew Burgess

comment:2 by Matthew Burgess, 19 years ago

Status: newassigned

comment:3 by Matthew Burgess, 19 years ago

Resolution: fixed
Status: assignedclosed

comment:4 by tushar@…, 19 years ago

Fixed in BLFS-SVN too.

Note: See TracTickets for help on using tickets.