Issue when reinstalling Module-Init-Tools

[manuel@…]

When reinstalling Module-Init-Tools the next warnings appears when running "make install":

Refusing to install sbin/insmod, move old utils first. Refusing to install sbin/modprobe, move old utils first. Refusing to install sbin/rmmod, move old utils first. Refusing to install sbin/depmod, move old utils first.

That meant that "rm -vf /sbin/{insmod,modprobe,rmmod,depmod}" should be performed before "make install" if reinstalling Module-Init-Tools.

[manuel@…]

Module-Init-Tools includes a

make moveold

target to solve the reinstallation issue. That command will create the following files:

/sbin/depmod.old /sbin/insmod.old /sbin/modinfo.old /sbin/modprobe.old /sbin/rmmod.old /usr/share/man/man8/depmod.old.8 /usr/share/man/man8/insmod.old.8 /usr/share/man/man8/lsmod.old.8 /usr/share/man/man8/modinfo.old.8 /usr/share/man/man8/modprobe.old.8 /usr/share/man/man8/rmmod.old.8

Plus the circular symlinks

/sbin/lsmod.old symlink to ../bin/lsmod.old /bin/lsmod.old symlink to /sbin/lsmod.old

To get rid of all that files, in jhalfs-X the following commands was added after "make install":

rm -v /usr/share/man/man8/*.old.8 rm -v /bin/lsmod.old rm -v /sbin/*.old

[dbn.lists@…]

Manuel, instead of using make moveold, could you try something different? The behavior that module-init-tools bombs because there isn't a .old file is because Makefile is calling install-with-care instead of install. Could you see what happens if you do

make INSTALL=install install

This should override the use of install-with-care, which has this sillyness:

    /sbin/insmod|/sbin/lsmod|/sbin/modprobe|/sbin/rmmod|/sbin/depmod)
        if [ -f $DEST ] && [ ! -f $DEST.old ]; then
            echo Refusing to install $DEST, move old utils first. >&2
            exit 1
        fi

[manuel@…]

Yes, "make INSTALL=install install" work under jhalfs.

Now we need to know if that command is safe also when doing the reinstallation on a running system.

[archaic@…]

I just tried it. Tested with modprobe -r ide_cd and cdrom, then modprobe ide_cd and mounting a cdrom. The cdrom module loaded and the cd was mounted properly. All seems fine.

Fixed in r7571