less-394 is not detecting sigset_t

[robert@…]

We are getting a warning from Less: os.c:109: warning: 'sigsetmask' is deprecated (declared at /usr/include/signal.h:184)

This is caused because 'sigprocmask' replaces 'sigsetmask', and 'sigprocmask' depends on 'sigset_t', and 'sigset_t' is not being detected properly by configure.

So anyway, I committed the "less-394-signal_fix-1.patch" to fix it.

robert

[Matthew Burgess]

Can you define what you mean by "'sigset_t' is not being detected properly by configure" please? I get:

checking for _setjmp... yes
checking for sigprocmask... yes
checking for sigsetmask... yes
checking for snprintf... yes

in my logs. So, both the newer sigprocmask and the deprecated sigsetmask functions are detected If you still think there's a bug there, could you submit the patch upstream please? (see ​http://www.greenwoodsoftware.com/less/#bugs).

[robert@…]

I did report it upstream... The problem is this:

checking for sigset_t... no

Then in less.h:

#if HAVE_SIGPROCMASK #if HAVE_SIGSET_T #else #undef HAVE_SIGPROCMASK #endif

So when make(1) gets to building os.c the:

#if HAVE_SIGPROCMASK

gets skipped over and:

#if HAVE_SIGSETMASK

is the next match.

[robert@…]

I received an email today from greenwoodsoftware (the Less maintainers) saying that the "less-394-signal_fix-1.patch" was accepted and will be in the next Less release.

[Jeremy Huntwork]

Milestone 6.3 deleted