Opened 18 years ago

Closed 18 years ago

Last modified 17 years ago

#1935 closed defect (wontfix)

gcc-4.1.1 upstream bugfixes

Reported by: Matthew Burgess Owned by: Matthew Burgess
Priority: normal Milestone:
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

As reported by Alexander Patrakov via Archaic:

echo | /lfs-livecd/packages/gcc/gcc-build/./gcc/xgcc
-B/lfs-livecd/packages/gcc/gcc-build/./gcc/ -B/usr/i486-pc-linux-gnu/bin/
-B/usr/i486-pc-linux-gnu/lib/ -isystem /usr/i486-pc-linux-gnu/include -isystem
/usr/i486-pc-linux-gnu/sys-include -E -dM - | \
          sed -n 's/^#define \([^_][a-zA-Z0-9_]*\).*/\1/p ; \
                s/^#define \(_[^_A-Z][a-zA-Z0-9_]*\).*/\1/p' | \
          sort -u > tmp-macro_list
sed: -e expression #1, char 88: unterminated address regex

Attachments (2)

gcc-4.1.1-newmake-1.patch (1.3 KB ) - added by Matthew Burgess 18 years ago.
gcc-4.1.1-fixes-1.patch (8.4 KB ) - added by alexander@… 18 years ago.
Adds more backoprted bugfixes

Download all attachments as: .zip

Change History (14)

by Matthew Burgess, 18 years ago

Attachment: gcc-4.1.1-newmake-1.patch added

by alexander@…, 18 years ago

Attachment: gcc-4.1.1-fixes-1.patch added

Adds more backoprted bugfixes

comment:1 by alexander@…, 18 years ago

Please use the new -fixes-1 patch instead. It also fixes some cases of silent miscompilation.

It would be also nice to backport ICE fixes, but I did not do that because the LiveCD build doesn't hit any ICE.

comment:2 by alexander@…, 18 years ago

Summary: gcc-4.1.1 & make-3.81 are incompatiblegcc-4.1.1 upstream bugfixes

comment:3 by Matthew Burgess, 18 years ago

Owner: changed from lfs-book@… to Matthew Burgess
Status: newassigned

Am I right in thinking that the upstream-fixes patch should be applied to all 3 passes of GCC? The host may well be running Make-3.81 after all.

comment:4 by alexander@…, 18 years ago

It is certainly the safest option. However, the Make-3.81 bug affects only installation of the fixincludes script, something we don't care about. Other bugfixes are vital if one adds -Os to CFLAGS.

comment:5 by alexander@…, 18 years ago

FIXME: the patch is incomplete, e.g., it doesn't include the fix for PR 26719.

comment:6 by Matthew Burgess, 18 years ago

OK, the patch for PR26719 (and also PR27795 & PR27639) is at http://gcc.gnu.org/ml/gcc-patches/2006-07/msg00898.html. Another patch (for PR27937) at http://gcc.gnu.org/ml/gcc-patches/2006-07/msg00229.html was committed following discussions related to that original patch but needs an additional trivial fix mentioned at http://gcc.gnu.org/ml/gcc-patches/2006-07/msg01057.html. I'll put a consolidated patch together tonight, and test it out. No doubt once this is all done, GCC-4.1.2 will be released rendering all this effort meaningless :-)

comment:7 by Matthew Burgess, 18 years ago

Well, those patches have rejections all over the place. As it is, GCC-4.1.2-RC1 is due out anytime, meaning the final release won't be too far away. I'm tempted to just wait until then to get these fixes. As this bug is 2 months old anyway, is it unreasonable to wait for another couple of weeks? If not, I'd appreciate someone else working on getting the patches mentioned above into a state where they'll apply cleanly.

comment:8 by alexander@…, 18 years ago

Not fixing this bug (maybe even without PR 26719, as it is too complex) would lead to the word "Official" being dropped from the unstable LiveCD name.

comment:9 by Matthew Burgess, 18 years ago

Why would you have to drop the "Official" designation of the LiveCD? You already build Linux with patches that aren't in the LFS book (reiser4 and tulip-is-not-a-proper-driver-for-dm910x.patch), so why would using an additional patch in GCC cause problems with the officiality of the LiveCD?

That said, I'll apply the fixes patch to the book, as it does remove the incompatibility with Make. I'll leave the fixes for PR26719 et al until GCC-4.1.2 comes out, which, if all goes well, will be in about a week: http://gcc.gnu.org/ml/gcc/2007-01/msg01223.html.

comment:10 by alexander@…, 18 years ago

Then it surely makes sense to wait a bit.

comment:11 by Matthew Burgess, 18 years ago

Resolution: wontfix
Status: assignedclosed

OK, I'll close this as WONTFIX then. We'll pick the bug fixes up in 4.1.2.

comment:12 by Jeremy Huntwork, 17 years ago

Milestone: 6.3

Milestone 6.3 deleted

Note: See TracTickets for help on using tickets.