Opened 16 years ago

Closed 16 years ago

#2166 closed defect (fixed)

Flex-2.5.34 Test Suite

Reported by: randy@… Owned by: ken@…
Priority: normal Milestone: 7.0
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

I find it odd that the Development books says this:

"The testsuite in this version of Flex does nothing useful before it ends with an error."

In fact, it clearly states at the end of the tests that 44 of 46 tests passed, and it identifies the 2 that do not pass.

Here are a couple of trivial sed commands to fix the input files for the tests that fail so that the test suite will "do something useful". :-)

sed -i '55 s|
' tests/test-pthread/scanner.l

sed -i -e '1 i/*' -e '21 i*/' tests/test-c++-multiple-scanners/scanner-{1,2}.l

Change History (4)

comment:1 by randy@…, 16 years ago

Man, do I hate Wiki's. Trying again.

sed -i '55 s|^    ||' tests/test-pthread/scanner.l
sed -i -e '1 i/*' -e '21 i*/' tests/test-c++-multiple-scanners/scanner-{1,2}.l

comment:2 by ken@…, 16 years ago

Owner: changed from lfs-book@… to ken@…
Status: newassigned

Yes, mea culpa - the format of the output in my logs (particularly the large amount of whitespace or blank lines) made me think nothing useful was going on. Later, I noticed on one of my clfs builds that there was indeed something at the end of the log. The silence until now made me think nobody is using the development book, or else nobody cares about the testsuites.

Anyway, I figured the problem would probably disappear when 2.5.35 goes in to the book. I'm not building x86 development systems at the moment, but I'll add your seds to my list of things to do. Thanks.

comment:3 by Marty Jack, 16 years ago

Flex 2.5.35 has been out for a while and solves the comment regression that leads to the test system failure. Wouldn't it be preferable to upgrade to it rather than sedding out the failure?

  • Marty

comment:4 by Jeremy Huntwork, 16 years ago

Resolution: fixed
Status: assignedclosed

Upgrade already done, so I guess that supercedes this ticket. Sorry if I stepped on your toes, Ken. I upgraded before I noticed this ticket.

Fixed in r8532.

Note: See TracTickets for help on using tickets.