#242 closed defect (fixed)
patch 2.5.4 needs -D_GNU_SOURCE on PPC
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | highest | Milestone: | |
| Component: | Book | Version: | CVS |
| Severity: | normal | Keywords: | |
| Cc: |
Description
On Sat, 22, Dec, 2001 at 03:18:26PM +0100, Jean Charles Andlauer spoke thus..
Hello again,
As the original poster, I confirm that:
- patch-2.5.4 does not work correctly under PPC if it was made with the
default CFLAGS,
- Patch-2.5.4 works correctly under PPC if it was made with
CFLAGS=-D_GNU_SOURCE,
- That most patch RPMs I have found make patch with CFLAGS=-D_GNU_SOURCE.
Somebody else commented that this was discussed a few months back: See also the thread: http://archive.linuxfromscratch.org/mail-archives/lfs-dev/2001/09/0736.html
We need to check it doesn't bugger up compilation on x86 platforms. If it doesn't I suggest just adding it to the book with a comment as to why it's there.
Change History (10)
comment:1 by , 22 years ago
comment:2 by , 22 years ago
| Priority: | high → highest |
|---|
comment:3 by , 22 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 22 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
added to book in ch5 and 6 along with explanation
comment:5 by , 22 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:7 by , 22 years ago
| Owner: | changed from to |
|---|---|
| Status: | reopened → assigned |
comment:8 by , 22 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:9 by , 22 years ago
| Keywords: | VERIFIED added |
|---|
confirmed that instructions have been added and don't seem to break anything on x86. from reports on lfs-dev, it works for PPC so verifying it.
comment:10 by , 22 years ago
| Keywords: | VERIFIED removed |
|---|
you probably wanted to close it too, so am closing now.
It's also needed on m68k