getpids() bug in lfs/init.d/functions, as of lfs-bootscripts-20090523

[Jeremy Henty]

The definition of getpids() is:

getpids() {

if [ -z "${PIDFILE}" ]; then

pidofproc -s -p "${PIDFILE}" $@

else

pidofproc -s $@

fi base="${1##*/}"

}

This is plainly wrong: the two clauses of the if statement should be swapped. NB: all the other uses of pidofproc() in this file are correct: the then clause of the 'if -z "$..>"' statement calls pidofproc() without the -p flag and the else clause calls it with the -p flag.

[bdubbs@…]

This is an interesting bug. I note that none of the lfs or blfs files use this function. The comment says:

# This will ensure compatibility with previous LFS Bootscripts

The last instance of use was removed in change r8075 in April of 2007. Perhaps we should just remove the function completely.

[Matthew Burgess]

Fixed in r9040 and r9041.