MPFR 2.4.2 fails to build with GMP 5.0.0 (And some other important MPFR patches)

[willimm]

When I was looking at the patches for MPFR on their website, I found a issue with GMP5 and MPFR 2.4.2: configure fails due to the fact that both BITS_PER_MP_LIMB and mpn_sqr_n were removed from GMP in version 5.0.0, and configure checks for these.

More info here:

​http://websympa.loria.fr/wwsympa/arc/mpfr/2010-01/msg00008.html

The patch is here:

​http://www.mpfr.org/mpfr-current/patch03

Also, there are some other patches for MPFR 2.4.2:

patch01 fixes, according to the site: "If the mpfr_sin_cos function is called on the minimum positive number or its opposite allowed by the current MPFR implementation (in the largest exponent range) and the rounding mode is toward zero or equivalent, then an underflow occurs but the underflow flag is not set. This bug in fixed by the sin_cos_underflow patch (which also provides additional tests of mpfr_sin_cos to trigger this bug)." This patch is located here:

​http://www.mpfr.org/mpfr-current/patch01

patch02 allows MPFR to build with GCC 4.4.* under MIPS, which dosen't affect us, but would probaly affect CLFS, but may as well apply the patch to avoid offset and/or fuzz:

​http://www.mpfr.org/mpfr-current/patch02

I think it would probaly be a good idea to consiladte these patches into one, like we did with vim, bash, and readline.

Marking as a blocker due to one of the patches fixing a severe issue with GMP 5.0.0 that keeps it from compiling.

[Matthew Burgess]

I'm confused. None of my builds have encountered a failure in this area. The error report you link to is from an HPUX 64bit host. If you can reproduce this on a Linux 32-bit/64-bit build then please re-open, and attach your build logs.

[willimm]

Replying to matthew@…:

I'm confused. None of my builds have encountered a failure in this area. The error report you link to is from an HPUX 64bit host. If you can reproduce this on a Linux 32-bit/64-bit build then please re-open, and attach your build logs.

The GMP issue has to do with passing --with-gmp-build to configure. In the INSTALL file:

--with-gmp-build=DIR    assumes that DIR contains the source of GMP and
                        enables the use of GMP internals.
                        Try to set CC/CFLAGS to GMP's ones. This is not
                        guaranteed to work as the configure script does
                        some compiler tests earlier, and the change may
                        be too late.
                        Warning! This option and the group of options
                        --with-gmp are mutually exclusive

We don't pass that option, so we don't need the patch. But, then again, the other two patches are somewhat important: One of them fixes a underflow error in mpfr_sin_cos, and the other one fixes a MIPS Gcc 4.4.0 issue, which affects CLFS. I would reopen this ticket, but rename it to "MPFR upstream patches".