Fix to tcl and expect package name title

[Gilles Espinasse]

As expect version is now without '-' between name and version, title and lib file names were not fixed, same for tcl title.

I fixed too the changelog for tcl and expect real package names.

I don't know yet if this is related but jhalf lfs svn broke on expect. In the Makefile, the 3 call (remove_existing_dirs, unpack, get_pkg_root_LUSER) are missing.

Did you consider moving tcl/expect/dejagnu later on chap05 as explained on 2791? That give better test suite result.

[Gilles Espinasse]

name fixes for tcl and expect titles, for libexpect

[Gilles Espinasse]

Move tcl/expect/dejagnu later to have a better expect testsuite result

[Matthew Burgess]

Gilles,

Did you do an 'svn up' of your jhalfs-trunk checkout before trying to build with the upgraded expect package committed? I did a full build with ALFS revision 3534 (​http://wiki.linuxfromscratch.org/alfs/changeset/3534/jhalfs) and had no issues.

I don't see the point in changing the package titles as your patch does. The fact that, IMO, upstream misname their tarballs, doesn't mean our page titles should be similarly misnamed.

Also, I don't feel the need to apply your testsuite patch, and to be honest, I think we should just remove all mentions of the testsuites for chapter 5 packages as they depend on the host too much to be of any use for us. That, however, is a discussion for -dev, so moving there.

Regards,

Matt.

[Matthew Burgess]

Actually, I'm not going to even bother raising this on -dev :) Here's the relevant bit of the book, from 4.6:

Experience has shown that there is little to be gained from running the test suites in Chapter 5. There can be no escaping the fact that the host system always exerts some influence on the tests in that chapter, often causing inexplicable failures. Because the tools built in Chapter 5 are temporary and eventually discarded, we do not recommend running the test suites in Chapter 5 for the average reader. The instructions for running those test suites are provided for the benefit of testers and developers, but they are strictly optional.}}}

Also, your testsuite patch would mean that the host would need to have expect, tcl & dejagnu installed so that the chapter 5 toolchain tests can be run.

[Gilles Espinasse]

Did you do an 'svn up' of your jhalfs-trunk checkout before trying to build with the upgraded expect package committed?

thank, that fixed jhalf build until I was hit by ../vim-7.3-lang.*: Cannot open I remember something need to be changed on config for that.

I don't see the point in changing the package titles as your patch does. The fact that, IMO, upstream misname their tarballs, doesn't mean our page titles should be similarly misnamed.

I don't disagree for the misnaming perception. But I am afraid tcl is now consistant without the '-' and expect package look now to follow the same convention. Anyway libexpect name should be fixed.

Also, your testsuite patch would mean that the host would need to have expect, tcl & dejagnu installed so that the chapter 5 toolchain tests can be run.

This is my error. I just find that my build system miss without reason many chapter05 tests. As I had rebuild with tcl/expect/dejagnu at the end of chap05 with only less errors in expect, I wrongly conclude that that was the right thing.

tcl/expect/dejagnu are not rebuild later and that's hard to upgrade one of those packages when you do not have a test suite that you can trust.

Maybe build tcl/expect/dejagnu first at their actual place and test them only later at end of chap05. Should be only reserved for the extrem tests addict.

[Gilles Espinasse]

Or don't test on chapter05 packages that are build and tested on chapter06. And move tcl/expect/dejagnu at the end on chapter05 where they could be more reliabily tested.