Opened 12 years ago

Closed 12 years ago

#3319 closed task (wontfix)

dejagnu patch for next test after a test error

Reported by: Gilles Espinasse Owned by: lfs-book@…
Priority: normal Milestone: 7.4
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

Fedora has a patch since a long time that fix an issue with runtest.

The patch is commited upstream since 2011, see

http://git.savannah.gnu.org/gitweb/?p=dejagnu.git;a=commitdiff;h=6d2e2d3791bcea70131a6cf64a0a5223333a7b8e

Patch is not include in 1.5.1 release that is 2 weeks old, as the change is only in master branch, not in dejagnu-1.5 branch.

You could see the issue while going in testsuite of your favorite package using dejagnu testsuite (site.exp is needed) and do echo 'perror foo' >a.exp; echo 'pass bar' >b.exp; runtest -a a.exp b.exp

You will see PASS on b.exp test if runtest.exp is fixed but UNRESOLVED if your version is not fixed.

Patch is dated from 2008, sometime, progress is very slow to happen. Original message http://lists.gnu.org/archive/html/bug-dejagnu/2008-08/msg00001.html

Change History (5)

comment:1 by Gilles Espinasse, 12 years ago

A slightly different subject, but dejagnu focused.

I don't see a reason why dejagnu test suite is run after make install and not before. 'make check' was added on LFS-6.2.

comment:2 by bdubbs@…, 12 years ago

There is no make. I'm not sure make check would work in an LFS environment.

EXPECT=/usr/bin/expect; export EXPECT; 

I don't think the above would work unless the host has expect installed. For lfs, it is in /tools/bin.

comment:3 by bdubbs@…, 12 years ago

Looking again at the main description of this ticket, I'm not sure it's necessary to make the patch for LFS. AFAIK, it doesn't affect any of the tests in LFS and we only install dejagnu on /tools.

A patch for the BLFS installation of dejagnu may be appropriate.

comment:4 by Gilles Espinasse, 12 years ago

In fact, I looked more if the patch is used somewhere. Debian, OpenSuse or Gentoo do not have that patch. So I can't say it is widely used.

As a first test failing is needed to trigger the issue, you need a package with at least an error (and gdb has more than one in my build).

comment:5 by bdubbs@…, 12 years ago

Resolution: wontfix
Status: newclosed

Marking as wontfix. The patch referenced above was made in March 2011 and there was a new version of the package in March of this year. Upstream didn't think it worthy of including, so I don't see why we should add it.

Note: See TracTickets for help on using tickets.