Opened 6 years ago

Closed 6 years ago

#3809 closed task (fixed)

fix a warning in automake

Reported by: bdubbs@… Owned by: lfs-book@…
Priority: low Milestone: 7.8
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by bdubbs@…)

/usr/bin/automake is a perl script that generates a warning when using the latest perl.

Fix by:

sed -i 's:/\\\${:/\\\$\\{:' /usr/bin/automake

Changes /\${ to /\$\{ (inserts a backslash before the left brace)

May be able to do this before configure.

Change History (4)

comment:1 by bdubbs@…, 6 years ago

Description: modified (diff)

Fix formatting of the description.

comment:2 by Armin, 6 years ago

I'd prefer if you didn't modify the installed files. You should be able to modify it before ./configure, as done with other packages that need pathching.

Also, if you get to it before I do, please fix intltool too:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=788705

Might be something similar. There's a patch on that bug report.

comment:3 by bdubbs@…, 6 years ago

It looks like the patch missed one:

$ grep '\\\${' intltool-update.in
    if ($str =~ /^(.*)\${?([A-Z_]+)}?(.*)$/)
        $sub = $varhash{$2} if defined $varhash{$2} and $varhash{$2} !~ /\${?$2}?/;
        $varhash{"PACKAGE_NAME"} = $name if (not $name =~ /\${?AC_PACKAGE_NAME}?/);
        $varhash{"PACKAGE"} = $name if (not $name =~ /\${?PACKAGE}?/);
        $varhash{"PACKAGE_VERSION"} = $version if (not $name =~ /\${?AC_PACKAGE_VERSION}?/);
        $varhash{"VERSION"} = $version if (not $name =~ /\${?VERSION}?/);
        $varhash{"PACKAGE_NAME"} = $name if (not $name =~ /\${?AC_PACKAGE_NAME}?/);
        $varhash{"PACKAGE"} = $name if (not $name =~ /\${?PACKAGE}?/);
        $varhash{"PACKAGE_VERSION"} = $version if (not $name =~ /\${?AC_PACKAGE_VERSION}?/);
        $varhash{"VERSION"} = $version if (not $name =~ /\${?VERSION}?/);
        $varhash{"PACKAGE_BUGREPORT"} = $bugurl if (defined $bugurl and not $bugurl =~ /\${?\w+}?/);

They missed the line starting with '$sub ='

I haven't checked, but I think the same sed in the description would work.

comment:4 by bdubbs@…, 6 years ago

Resolution: fixed
Status: newclosed

Fixed at version 10925.

Note: See TracTickets for help on using tickets.