Opened 8 years ago
Closed 8 years ago
#3971 closed defect (fixed)
Sysklogd sed should use int, not int*
Reported by: | Bryan Kadzban | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | 7.10 |
Component: | Book | Version: | SVN |
Severity: | normal | Keywords: | |
Cc: |
Description
Sysklogd build instructions (in chapter 6) replace "union wait" with "int*" for the type of the "status" variable.
But then two lines below, the code does:
wait3(&status, WNOHANG, (struct rusage *) NULL)
which ends up passing the wait3 call an int**. I don't think it matters a ton, because the value stored in status is never looked at, but it's still weird. I think the sed should be:
sed -i 's/union wait/int/' syslogd.c
instead of:
sed -i 's/union wait/int*/' syslogd.c
Note:
See TracTickets
for help on using tickets.
Looking at the code, it's hard to see how the change makes a difference, but you are right. It is technically incorrect. I'll fix it in my next commit.