Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4453 closed task (fixed)

Multilib: 6.23 gcc instructions useless

Reported by: thomas Owned by: lfs-book
Priority: normal Milestone: 9.0
Component: Book Version: multilib
Severity: normal Keywords:


In 6.23 we do a

sed -e '/m64=/s/lib64/lib/' \
    -i.orig gcc/config/i386/t-linux64
cat > gcc/config/i386/t-linux64 <<"EOF"
MULTILIB_OPTIONS    = $(subst $(comma),/,$(TM_MULTILIB_CONFIG))
MULTILIB_DIRNAMES   = $(patsubst m%, %, $(subst /, ,$(MULTILIB_OPTIONS)))
MULTILIB_OSDIRNAMES = m64=../lib$(call if_multiarch,:x86_64-linux-gnu)
MULTILIB_OSDIRNAMES+= m32=../lib32$(call if_multiarch,:i386-linux-gnu)
MULTILIB_OSDIRNAMES+= mx32=../libx32$(call if_multiarch,:x86_64-linux-gnux32)

which is useless. First we do a sed but then, we recreate the whole file via cat<<EOF. The two statements could be replaced/simplified by

sed -e '/m64=/s/lib64/lib/'  \
    -e '/m32=/s/m32=.*/m32=..\/lib32$(call if_multiarch,:i386-linux-gnu)/' \
    -i.orig gcc/config/i386/t-linux64

Same in chap 5.5 (gcc-pass1) and 5.11 (gcc-pass2)

Change History (2)

comment:1 by thomas, 4 years ago

Resolution: fixed
Status: newclosed

Fixed in r11575

comment:2 by Bruce Dubbs, 4 years ago

Milestone: 8.59.0

Milestone renamed

Note: See TracTickets for help on using tickets.