Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#4468 closed task (fixed)

e2fsprogs-1.45.1

Reported by: Douglas R. Reno Owned by: lfs-book
Priority: normal Milestone: 9.0
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

New point version

Attachments (1)

e2fsprogs-1.45.1-fix_crond_dir-1.patch (886 bytes ) - added by thomas 2 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by thomas, 2 years ago

I'd suggest to add the option --with-crond-dir=no to instructions to avoid a strange behavior while installing e2scrub_all.

Looks like e2scrub_all gets installed in build/yes/ if leaving out that option (since the default is set to 'yes' in that case). The idea seems to be that the install should do

install e2scrub_all.cron /etc/cron.d/e2scrub_all

but it results in

install e2scrub_all.cron yes/e2scrub_all

Other option is to specify a full-qualified path like --with-crond-dir=/etc/cron.d which looks like that it should be the default if nothing is set. Unfortunatly due to the bug, install does use 'yes' literally if not set. We could also specify --with-crond-dir=/usr/share/e2fsprogs and later in BLFS when installing a cron, we could pull the file from that dir and place it in cron's directories.

Btw, if interested in that issue, see http://lists.linuxfromscratch.org/pipermail/lfs-dev/2019-May/073106.html - and don't get confused with e2scr_all_cron and e2scrub_all.cron - thats two different things and the second one gets lost in space due to the bug...

Issue is reported to Ted Tso, no answer yet.

comment:3 by Bruce Dubbs, 2 years ago

Resolution: fixed
Status: newclosed

Fixed at revision 11607.

comment:4 by thomas, 2 years ago

Just a comment on (closed) ticket. Got a fix from Ted:

commit a9cf13748946ce9ceb56f962fc22b965048d2cef
Author: Theodore Ts'o <tytso@mit.edu>
Date:   Wed May 22 13:03:38 2019 -0400

    configure: fix test where cron is not installed on a non-systemd
system
    
    Reported-by: thomas@linuxfromscratch.org
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/configure b/configure
index 205b2d6dc..065bff761 100755
--- a/configure
+++ b/configure
@@ -13150,7 +13150,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result:
$ac_cv_lib_blkid_blkid_probe_get_topology" >&5
 $as_echo "$ac_cv_lib_blkid_blkid_probe_get_topology" >&6; }
 if test "x$ac_cv_lib_blkid_blkid_probe_get_topology" = xyes; then :
-  $as_echo "#define HAVE_BLKID_PROBE_GET_TOPOLOGY 1" >>confdefs.h
+
+$as_echo "#define HAVE_BLKID_PROBE_GET_TOPOLOGY 1" >>confdefs.h
 
 fi
 
@@ -13191,7 +13192,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result:
$ac_cv_lib_blkid_blkid_probe_enable_partitions" >&5
 $as_echo "$ac_cv_lib_blkid_blkid_probe_enable_partitions" >&6; }
 if test "x$ac_cv_lib_blkid_blkid_probe_enable_partitions" = xyes;
then :
-  $as_echo "#define HAVE_BLKID_PROBE_ENABLE_PARTITIONS 1"
>>confdefs.h
+
+$as_echo "#define HAVE_BLKID_PROBE_ENABLE_PARTITIONS 1" >>confdefs.h
 
 fi
 
@@ -14511,6 +14513,8 @@ if test "x${with_crond_dir}" != "xno"; then :
 
                if test -d "/etc/cron.d"; then :
   with_crond_dir="/etc/cron.d"
+else
+  have_crond="no"; with_crond_dir=""
 fi
 
 fi
diff --git a/configure.ac b/configure.ac
index 3b86c1a14..cf03444d8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1674,7 +1674,8 @@ AS_IF([test "x${with_crond_dir}" != "xno"],
        AS_IF([test "x${with_crond_dir}" = "xyes"],
          [
                AS_IF([test -d "/etc/cron.d"],
-                 [with_crond_dir="/etc/cron.d"])
+                 [with_crond_dir="/etc/cron.d"],
+                 [have_crond="no"; with_crond_dir=""])
          ])
        AC_MSG_CHECKING([for system crontab dir])
        crond_dir="${with_crond_dir}"

No need to specify the --with-crond-dir=no option at configure command anylonger (and no 'yes'-directory). Find the (reformatted) patch attached.

comment:5 by Bruce Dubbs, 2 years ago

Milestone: 8.59.0

Milestone renamed

Note: See TracTickets for help on using tickets.