Opened 21 years ago
Closed 21 years ago
#488 closed defect (fixed)
checkfs - correction in fsck return codes interpretation
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Book | Version: | CVS |
| Severity: | normal | Keywords: | |
| Cc: |
Description
fsck from e2fsprogs 1.32 returns 3 in case errors were found and corrected and the system needs to be rebooted ( 1 - errors found and corrected OR system needs to be rebooted).
IMHO the script should be modified like:
- if [ "error_value" = 2 ]
| [ "error_value" = 3 ] |
....
- if [ "error_value" -gt 2 -a "error_value" -lt 16 ]
+ if [ "error_value" -gt 3 -a "error_value" -lt 16 ]
Also maybe a timeout instead just wainting for enter to reboot (but not in case of halt)
Change History (3)
comment:1 by , 21 years ago
| Priority: | high → normal |
|---|
comment:2 by , 21 years ago
I think this is related to the HTREE bug mentioned in this thread:
http://archive.linuxfromscratch.org/mail-archives/lfs-dev/2003/03/0094.html
I don't know if the issue has been fixed in e2fsprogs-1.33 (here http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=181615) T. Ts'o said it would, but I can't find it in the changelog.
comment:3 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Not related to the HTREE problem which is now no longer a problem anyway.
The point about adding a timeout could be valid but Gerard's comment seems to indicate this is not appropriate, and seeing he is the current bootscripts maintainer...
The original bug is now fixed with the release of lfs-bootscripts-1.12 which will appear in LFS 5.0 shortly. Thanks for the report. Closing.
Not sure if the suggested changes are appropriate, I've heard more things here and there (without remembering where exactly so I cannot provide links right now) that more return values have changed, so let's give the checkfs a thorough look-over to make sure it's doing the right thing in all return value cases.