Opened 21 years ago
Closed 20 years ago
#536 closed defect (fixed)
Replace Bison patch with a sed.
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | high | Milestone: | |
| Component: | Book | Version: | CVS |
| Severity: | normal | Keywords: | |
| Cc: |
Description
See URL for details.
Attachments (4)
Change History (13)
by , 21 years ago
| Attachment: | bison.patch added |
|---|
by , 21 years ago
| Attachment: | bison-1.875-alt-no-unused.patch added |
|---|
patch to bison-1.875 that fixes some issue with pwlib
by , 21 years ago
| Attachment: | bison-unused-label.patch added |
|---|
patch to bison to only use labels actually used
by , 21 years ago
| Attachment: | bison-attribute-unused.patch added |
|---|
fixes bug in Bison 1.875, wrt g++, and attribute ((unused))
comment:1 by , 21 years ago
| attachments.isobsolete: | 0 → 1 |
|---|
comment:2 by , 21 years ago
| attachments.description: | path to bison-1.875 that fixes some issue with pwlib → patch to bison-1.875 that fixes some issue with pwlib |
|---|
comment:3 by , 21 years ago
| attachments.isobsolete: | 0 → 1 |
|---|
comment:4 by , 21 years ago
it may be easier to do a diff between bison-1.875 and bison-1.875a and to edit the resulting diff for useless stuff. :)
comment:5 by , 21 years ago
Then we could just as well just go with 1.875a.
Or wait for the next version, I don't think LFS 5.0 will be out for quite some time... :-)
comment:6 by , 21 years ago
I can verify that the pwlib patch fixes the build of pwlib. However, only the first hunk (data/yacc.c) is actually needed to make it build. But for the sake of consistency, might be best to include both hunks. I vote that it goes into the book.
I cannot vouch for the other patches. In fact, I am doubtful of the OOo patch. The change does not appear in the diff between 1.875 & 1.875a and 1.875a is supposed to be OOo friendly. Go figure.
comment:7 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:8 by , 20 years ago
| Priority: | highest → high |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
| Summary: | Find Bison patch, add it. → Replace Bison patch with a sed. |
This patch can be replaced with a simple sed one-liner:
sed -i '/unused/d' data/yacc.c
Tested by building everything I could (including pwlib and OpenOffice). Reopening bug and retitling accordingly.
comment:9 by , 20 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
This patch can be replaced with a simple sed one-liner:
Actually, scratch that. It works fine, but buggers up the test suite if "-Wall" happens to be in the current CFLAGS. The current patch stays. Reclosing.
patch to bison to fix some issues with OOo