Opened 2 years ago

Closed 2 years ago

#5488 closed defect (fixed)

Revert the problematic part of 340e17adc67a1d7dc050fed51e384122f425e458 (ncurses-6.5)

Reported by: Bruce Dubbs Owned by: lfs-book
Priority: normal Milestone: 12.2
Component: Book Version: git
Severity: blocker Keywords:
Cc:

Description

New minor version.

Change History (9)

comment:1 by Xi Ruoyao, 2 years ago

What's going on? Didn't we already update to it in d0ca5ead4668649d96eb6a9ed9e0269c15dfbe01? Why it's rolled back in 340e17adc67a1d7dc050fed51e384122f425e458? Note that the roll-back breaks 3abde5946b237bcfd09af72acefff799356b9802, causing a lot of bullsh*t in lfs-dev.

comment:2 by Xi Ruoyao, 2 years ago

And 340e17adc67a1d7dc050fed51e384122f425e458 also rolls back a Glibc security update, introducing a vulnerability to LFS.

I'd say this commit needs a revert.

comment:3 by Xi Ruoyao, 2 years ago

Summary: ncurses-6.5 → Revert the problematic part of 340e17adc67a1d7dc050fed51e384122f425e458 (ncurses-6.5)
Type: enhancement → defect

I'd suggest a full revert of 340e17adc67a1d7dc050fed51e384122f425e458 and then apply the correct part of it again so the git history would be easier to read. But if it'll cause too much overhead we can just do a partial revert.

comment:4 by Xi Ruoyao, 2 years ago

Severity: normal → blocker

comment:5 by Bruce Dubbs, 2 years ago

Probably my fault. I've been distracted lately by non-LFS events. Please fix when you can.

comment:6 by Xi Ruoyao, 2 years ago

I'll clean the mess and run jhalfs overnight. If it's fine I'll commit tomorrow morning.

comment:7 by Xi Ruoyao, 2 years ago

Hmm I've changed my mind about full revert. Maybe a git cherry-pick d0ca5ead4668649d96eb6a9ed9e0269c15dfbe01 is enough.

comment:9 by Xi Ruoyao, 2 years ago

Resolution: → fixed
Status: new → closed
Note: See TracTickets for help on using tickets.