Opened 6 months ago
Closed 6 months ago
#5705 closed enhancement (fixed)
White space reduction? - LFS r12.3-36-systemd
| Reported by: | rhubarbpieguy | Owned by: | lfs-book |
|---|---|---|---|
| Priority: | low | Milestone: | 12.4 |
| Component: | Book | Version: | git |
| Severity: | normal | Keywords: | |
| Cc: |
Description (last modified by )
Are the following candidates to reduce white space?
chapter05/gcc-libstdc++.xml ../libstdc++-v3/configure \ --host=$LFS_TGT \ --build=$(../config.guess) \ --prefix=/usr \ --disable-multilib \ --disable-nls \ --disable-libstdcxx-pch \ ../libstdc++-v3/configure \ --host=$LFS_TGT \ --build=$(../config.guess) \ --prefix=/usr \ --disable-multilib \ --disable-nls \ --disable-libstdcxx-pch \ ----------------------------------------- chapter06/gcc-pass2.xml ../configure \ --build=$(../config.guess) \ --host=$LFS_TGT \ --target=$LFS_TGT \ LDFLAGS_FOR_TARGET=-L$PWD/$LFS_TGT/libgcc \ --prefix=/usr \ --with-build-sysroot=$LFS \ --enable-default-pie \ --enable-default-ssp \ --disable-nls \ --disable-multilib \ --disable-libatomic \ --disable-libgomp \ --disable-libquadmath \ --disable-libsanitizer \ --disable-libssp \ --disable-libvtv \ ../configure \ --build=$(../config.guess) \ --host=$LFS_TGT \ --target=$LFS_TGT \ LDFLAGS_FOR_TARGET=-L$PWD/$LFS_TGT/libgcc \ --prefix=/usr \ --with-build-sysroot=$LFS \ --enable-default-pie \ --enable-default-ssp \ --disable-nls \ --disable-multilib \ --disable-libatomic \ --disable-libgomp \ --disable-libquadmath \ --disable-libsanitizer \ --disable-libssp \ --disable-libvtv \ -------------------------------------------------------- chapter06/tar.xml ./configure --prefix=/usr \ --host=$LFS_TGT \ ./configure --prefix=/usr \ --host=$LFS_TGT \ -------------------------------------- chapter08/acl.xml ./configure --prefix=/usr \ --disable-static \ ./configure --prefix=/usr \ --disable-static \ --------------------------------------- chapter08/e2fsprogs.xml ../configure --prefix=/usr \ --sysconfdir=/etc \ --enable-elf-shlibs \ --disable-libblkid \ --disable-libuuid \ --disable-uuidd \ ../configure --prefix=/usr \ --sysconfdir=/etc \ --enable-elf-shlibs \ --disable-libblkid \ --disable-libuuid \ --disable-uuidd \ ------------------------------------------- chapter08/glibc.xml ../configure --prefix=/usr \ --disable-werror \ --enable-kernel=5.4 \ --enable-stack-protector=strong \ --disable-nscd \ ../configure --prefix=/usr \ --disable-werror \ --enable-kernel=5.4 \ --enable-stack-protector=strong \ --disable-nscd \ ------------------------------------------------------- chapter08/grub.xml ./configure --prefix=/usr \ --sysconfdir=/etc \ --disable-efiemu \ ./configure --prefix=/usr \ --sysconfdir=/etc \ --disable-efiemu \ ---------------------------------------- chapter08/libelf.xml ./configure --prefix=/usr \ --disable-debuginfod \ ./configure --prefix=/usr \ --disable-debuginfod \ ------------------------------------------- chapter08/libffi.xml ./configure --prefix=/usr \ --disable-static \ ./configure --prefix=/usr \ --disable-static \ --------------------------------------- chapter08/pkgconf.xml ./configure --prefix=/usr \ --disable-static \ ./configure --prefix=/usr \ --disable-static \
Change History (4)
comment:1 by , 6 months ago
| Description: | modified (diff) |
|---|
comment:2 by , 6 months ago
| Description: | modified (diff) |
|---|---|
| Priority: | normal → low |
Overall the list is good, but this is relatively low priority. My next scheduled update to LFS is at the end of the month and I'll address this then.
As for the min-kernel value, that needs to be addressed also. I noticed in one place it is used at the end of a sentence and inserts a space before the period. That's pretty trivial and hard to notice, but should be fixed. I'll do that too.
comment:3 by , 6 months ago
| Description: | modified (diff) |
|---|
Then I guess we'd move --with-kernel= lines to the last in Glibc configure commands (for both chapter 5 and 8).
comment:4 by , 6 months ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Made some changes slightly different from the above, but overall the spacing now looks a lot better.
Fixed at commit f6dbeeb1d.
Note:
See TracTickets
for help on using tickets.
At the very lease, for Glibc we won't remove all the "extra" spaces. We have:
<!-- 5.4 EOL is Dec 2025 so for LFS 12.5 we may consider moving to 5.10. Keep an extra whitespace here to align the trailing "\" in glibc configure command if y < 10 in x.y. --> <!ENTITY min-kernel "5.4 ">