alignment/blocking? - LFS r12.3-42-systemd

[rhubarbpieguy]

chapter08/systemd.xml

	 tar -xf ../../systemd-man-pages-257.3.tar.xz \
	     --no-same-owner --strip-components=1   \

	 tar -xf ../../systemd-man-pages-257.3.tar.xz \
	     --no-same-owner --strip-components=1     \
-------------------------------------------------------

 chapter08/tcl.xml

	 sed -e "s|$SRCDIR/unix/pkgs/tdbc1.1.10|/usr/lib/tdbc1.1.10|" \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10/generic|/usr/include|"    \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10/library|/usr/lib/tcl8.6|" \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10|/usr/include|"            \

	 sed -e "s|$SRCDIR/unix/pkgs/tdbc1.1.10|/usr/lib/tdbc1.1.10|" \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10/generic|/usr/include|"     \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10/library|/usr/lib/tcl8.6|"  \
	     -e "s|$SRCDIR/pkgs/tdbc1.1.10|/usr/include|"             \

[thomas]

I'd vote for not changing the XMLs of LFS and BLFS just for those alignments. If we need to put hands on them anyhow because of version upgrades or such, we might have a look to format matching the guidelines as long as we have strict ones.

Missalignments will continuously happen when at least one part of a version number goes from 9 to 10. Looks like that happened at the tcl example above. When you reduce the version from 1.1.10 to 1.1.9, the alignment will look perfectly. Unfortunatly, such a missalignment is often not easy to spot in the XMLs. In the XMLs, XML entities are used, for example

sed -e "s|$SRCDIR/unix/pkgs/tdbc&tdbc-ver;|/usr/lib/tdbc&tdbc-ver;|" \
    -e "s|$SRCDIR/pkgs/tdbc&tdbc-ver;/generic|/usr/include|"    \
    -e "s|$SRCDIR/pkgs/tdbc&tdbc-ver;/library|/usr/lib/tcl8.6|" \
    -e "s|$SRCDIR/pkgs/tdbc&tdbc-ver;|/usr/include|"            \
    -i pkgs/tdbc&tdbc-ver;/tdbcConfig.sh

which do hide the effective version number and in this case its not easy to tell where the \ has to be put. I think missalignments will happen all the time and they do not harm.

[Bruce Dubbs]

The alignment issue is a bit tricky when there are entities like &tdbc-ver; on some lines and not on others. It takes a special amount of attention when the length of the entity name differs from the entity contents by a significant amount.

I have a normal schedule of doing LFS updates at the beginning and middle of each month. Occasionally updates are needed at other times. These alignment issues are low priority but I like to get it right when they are pointed out to me.

I'll do this at the next update.

[Bruce Dubbs]

Fixed at commit de932d6de.