Opened 20 years ago

Closed 20 years ago

#900 closed defect (fixed)

udev-032

Reported by: djensen@… Owned by: lfs-book@…
Priority: lowest Milestone:
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

udev-032 needs new instructions install creates incorrect links in chapter-5

Attachments (4)

udev-032-etcdir-1.patch (1.3 KB ) - added by djensen@… 20 years ago.
adjusts udev.conf.in to use DESTDIR
udev-032-link-1.patch (918 bytes ) - added by djensen@… 20 years ago.
corrects the bad chapter-5 links
udev-etc-dir.patch (1.4 KB ) - added by kpfleming@… 20 years ago.
udev-032-etcdir-1.patch
udev-etc-dir.2.patch (2.3 KB ) - added by kpfleming@… 20 years ago.
udev-032-etcdir-2.patch

Download all attachments as: .zip

Change History (13)

by djensen@…, 20 years ago

Attachment: udev-032-etcdir-1.patch added

adjusts udev.conf.in to use DESTDIR

by djensen@…, 20 years ago

Attachment: udev-032-link-1.patch added

corrects the bad chapter-5 links

comment:1 by djensen@…, 20 years ago

change instructions to:

The installation creates links to /sbin when /tools/sbin is required. This patch corrects the prefix.

patch -Np1 -i ../udev-032-link-1.patch

Also assure that udev knows the correct location to look for its configuration files:

patch -Np1 -i ../udev-032-etcdir-1.patch

Now compile Udev:

make prefix=/tools

comment:2 by kpfleming@…, 20 years ago

I'd like to hold off on integrating these changes into unstable. My concerns are:

  • the DESTDIR in udev.conf patch is not correct, because DESTDIR paths should

not be hardcoded into anything (only prefix= paths should be)

  • there are seemingly extraneous extra arguments being passed to udev's

Makefile; it's possible that these were necessary with older versions

I'm running some tests right now to find out _exactly_ what should be changed from udev's defaults.

comment:3 by kpfleming@…, 20 years ago

OK, here are my comments:

The "bad links" patch is not necessary, if the udev build instructions are properly modified.

I did this:

unpack udev-032 make prefix=/tools make prefix=/tools install

After this, there were two problems that needed to be addressed:

  • the "/etc/udev" paths in /tools/etc/udev/udev.conf
  • the "/udev" paths in /tools/etc/udev/udev.conf

Everything else was fine. Yes, the symlink from udevstart to udev is absolute, but that is not a problem for LFS.

I have uploaded a replacement patch to correct the udev.conf file, which uses configdir instead of DESTDIR, since the Makefile already computes the proper configdir when prefix=/tools is used.

Here are my suggested replacement chapter 5 build instructions:

patch -p1 -i udev-032-etcdir-1.patch make prefix=/tools udevdir=/dev make prefix=/tools udevdir=/dev install cp ../udev-config-2.permissions /tools/etc/udev/permissions.d/00-lfs.permissions cp ../udev-config-1.rules /tools/etc/udev/rules.d/00-lfs.rules

No changes are needed in chapter 6.

by kpfleming@…, 20 years ago

Attachment: udev-etc-dir.patch added

udev-032-etcdir-1.patch

comment:4 by kpfleming@…, 20 years ago

attachments.isobsolete: 01

comment:5 by djensen@…, 20 years ago

i think this will fail install in chapter-5

$(INSTALL) -d $(DESTDIR)$(udevdir)

if DESTDIR is not set, user lfs attempts to install /dev if DESTDIR is set the etcdir becomes /tools/tools/etc been there, i think

comment:6 by kpfleming@…, 20 years ago

David's response is correct; here are the revised instructions.

patch -p1 -i udev-032-etcdir-1.patch make prefix=/tools udevdir=/tools/dev make prefix=/tools udevdir=/tools/dev install cp ../udev-config-2.permissions /tools/etc/udev/permissions.d/00-lfs.permissions cp ../udev-config-1.rules /tools/etc/udev/rules.d/00-lfs.rules

by kpfleming@…, 20 years ago

Attachment: udev-etc-dir.2.patch added

udev-032-etcdir-2.patch

comment:7 by kpfleming@…, 20 years ago

attachments.isobsolete: 01

comment:8 by kpfleming@…, 20 years ago

attachments.description: udev-032-etcdir-1.patchudev-032-etcdir-2.patch

comment:9 by jeremy@…, 20 years ago

Resolution: fixed
Status: newclosed

patch applied in unstable

Note: See TracTickets for help on using tickets.