gnome-shell-3.34.4

[Douglas R. Reno]

New point version

[Xi Ruoyao]

3.34.4
======
* Switch screen-recorder back to VP8 [Björn; #256]

[Bruce Dubbs]

At -j4; with tests

3.3 Elapsed Time -  gnome-shell-3.34.4
SBU=.127
1512 /usr/src/gnome-shell/gnome-shell-3.34.4.tar.xz SIZE (1.476 MB)
56032 kilobytes BUILD SIZE (54.718 MB)
md5sum : 692181c1a98be9e5f5b7e8738fd428ce  /usr/src/gnome-shell/gnome-shell-3.34.4.tar.xz

[0/1] Running all tests.
1/6 CSS styling support                     OK       0.37 s
2/6 insertSorted                            FAIL     0.17 s (exit status 1)
3/6 jsParse                                 OK       0.07 s
4/6 markup                                  FAIL     0.17 s (exit status 1)
5/6 params                                  OK       0.07 s
6/6 url                                     FAIL     0.17 s (exit status 1)

Did not have gdm installed. Should we move gdm to before gnome-shell?

[Xi Ruoyao]

Replying to bdubbs:

[0/1] Running all tests.
1/6 CSS styling support                     OK       0.37 s
2/6 insertSorted                            FAIL     0.17 s (exit status 1)
3/6 jsParse                                 OK       0.07 s
4/6 markup                                  FAIL     0.17 s (exit status 1)
5/6 params                                  OK       0.07 s
6/6 url                                     FAIL     0.17 s (exit status 1)

Did not have gdm installed. Should we move gdm to before gnome-shell?

These 3 failed tests need GDM. I retested them after installing GDM. Moving GDM to before gnome-shell is an option.

[Pierre Labastie]

Replying to bdubbs:

Did not have gdm installed. Should we move gdm to before gnome-shell?

You mean make gdm a non runtime dependency, don't you? It's not written anywhere that gnome components should be built in the book order.

[Xi Ruoyao]

Replying to pierre.labastie:

Replying to bdubbs:

Did not have gdm installed. Should we move gdm to before gnome-shell?

You mean make gdm a non runtime dependency, don't you? It's not written anywhere that gnome components should be built in the book order.

It's actually a dependency for test suite.

Strictly saying, GDM is not even an runtime dependency. It's possible to spawn gnome-shell UI with xinit.

[Pierre Labastie]

Replying to xry111:

Replying to pierre.labastie:

Replying to bdubbs:

Did not have gdm installed. Should we move gdm to before gnome-shell?

You mean make gdm a non runtime dependency, don't you? It's not written anywhere that gnome components should be built in the book order.

It's actually a dependency for test suite.

Actually, my point was that it was not useful to move it. But I think it should be in optional with "for tests" in parentheses.

Strictly saying, GDM is not even an runtime dependency. It's possible to spawn gnome-shell UI with xinit.

Yes it is, but are we sure that there is no added functionality when gdm is there? Anyway, we cannot make it both runtime and optional for tests...

[Douglas R. Reno]

Although I am able to install GDM before gnome-shell (I just confirmed that on my system), I think it's best to leave it in place for now. I will note that we have the following in the book right now:

To test the results, issue: ninja test. You must be running an X session to run the tests. Some will fail if GDM-3.34.1 is not installed. 

It's also listed in Runtime Dependencies.

[Douglas R. Reno]

Fixed at r22761