Opened 5 months ago

Closed 5 months ago

#14676 closed enhancement (fixed)

X264-20210211

Reported by: ken@… Owned by: ken@…
Priority: normal Milestone: 10.1
Component: BOOK Version: SVN
Severity: normal Keywords:
Cc:

Description (last modified by ken@…)

Current version, preparing for the 10.1 book

Renamed to 20210211 - last item in git log is 20210210 but files are dated 11th Feb.

Change History (5)

comment:1 by ken@…, 5 months ago

Owner: changed from blfs-book to ken@…
Status: newassigned

Changes since 2020-08-19:

commit b86ae3c66f51ac9eab5ab7ad09a9d62e67961b8a
Author: Henrik Gramner <henrik@gramner.com>
Date:   Wed Feb 10 15:40:32 2021 +0100

    x86inc: Add stack probing on Windows
    
    Large stack allocations on Windows need to use stack probing in order
    to guarantee that all stack memory is committed before accessing it.
    This is done by ensuring that the guard page(s) at the end of the
    currently committed pages are touched prior to any pages beyond that.

commit 38a76c7a00ca561e6b016c97662822f9a23c2ace
Author: Henrik Gramner <henrik@gramner.com>
Date:   Thu Feb 11 14:24:27 2021 +0100

    Silence false positive -Wformat-truncation warning

commit fa264466e70ecd99561bb450c3212e5111aed829
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Mon Feb 8 21:07:36 2021 +0300

    Fix MB stats
    
    Bug report by Zhengzhi Duan.

commit ee62f14d94fa183b02e51143761fba4073bfd01c
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Tue Feb 9 00:25:32 2021 +0300

    CI: Update macos URL to vlc-contrib

commit a7e2c6ab8ff884e90f47a03258756fb0ad9f2e06
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Mon Feb 1 22:32:37 2021 +0300

    Fix VBV overflow check for B-frames
commit 59c06095de90db362b959a4975d8cc6f1566dbdb
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Wed Jan 27 17:14:55 2021 +0300

    x86inc: Fix LOAD_MM_PERMUTATION for AVX-512

commit b3aadb76329d3c2aedac85142441476bbe5f002c
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Thu Jan 21 23:26:27 2021 +0300

    Fix PADH alignment
    
    Make pointers to padded buffers aligned both before and after padding.

commit e32bff16571e3d4047db50621b252adf44e4234c
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Tue Jan 26 20:43:34 2021 +0300

    Fix alignment of chroma buffer for weightp
    
    In 10-bit mode pixel_asd8 expects 16-byte alignment for pix1 and pix2.

commit 35417dcd65a57321fbadf98c9a4cff1cb741db4b
Author: Henrik Gramner <henrik@gramner.com>
Date:   Tue Jan 26 02:21:16 2021 +0100

    Makefile: Drop the -T argument to install
    
    It's not required, and BSD doesn't support it.

commit 544c61f082194728d0391fb280a6e138ba320a96
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Thu Jan 21 16:41:42 2021 +0300

    Fix use of nalu_process callback
    
    Broke after unifying of 8-bit and 10-bit libraries.
commit 045d3fdab5ab4e8358bb9a074dd09e9747fe430d
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Wed Jan 20 00:20:18 2021 +0300

    Fix weighting for B-frames
    
    This bug never occurs with the current reference management logic.
    Bug report by Lingjiang Fang.

commit e78664956807fed2cfbb6aab71bbe2be5609e1e8
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Fri Jan 22 03:51:23 2021 +0300

    Fix CAVLC encoding
    
    This bug mainly occurred when encoding with high bitrate (low QP).
    It did not occur when encoding in baseline or main profile.

commit 8e5e8340f074b4069eb40baa0bb1a2efcd445a45
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Sun Jan 24 16:28:24 2021 +0300

    Bump dates to 2021

commit c17d152d7b4e8591942a0020bdcd6c3988317b92
Author: Konstantin Pavlov <thresh@videolan.org>
Date:   Tue Nov 24 20:53:11 2020 +0300

    CI: Move macos to catalina builders

commit f7963f6a3ee131a194f0d637b96fd032bdab54a9
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Fri Jan 8 18:51:45 2021 +0300

    CI: Update URLs to the latest vlc-contrib
commit 0d754ec36013fee82978496cd56fbd48824910b3
Author: Martin Storsjö <martin@martin.st>
Date:   Mon Oct 26 10:01:33 2020 +0200

    gitlab-ci: Add build-only configurations with llvm-mingw targeting armv7/aarch64

commit 6bc7fe4f36ea95db77e6df6d76153dd5a2c770a0
Author: Henrik Gramner <henrik@gramner.com>
Date:   Sun Nov 29 14:38:07 2020 +0100

    configure: Fix endianness test when LTO is enabled through CFLAGS

commit 15e447f9b7b9c78fa89f373e3acb2438752a6b39
Author: Martin Storsjö <martin@martin.st>
Date:   Mon Oct 26 10:36:36 2020 +0200

    gitlab-ci: Remove the unused _PATH variable
    
    It became unused in cde9a93319bea766a92e306d69059c76de970190.

commit 8bd6d28025c9dcc101cb194f9141bcff3ea91500
Author: Janne Grunau <janne-x264@jannau.net>
Date:   Thu Oct 1 21:08:37 2020 +0000

    aarch64/asm: optimize cabac asm
    
    0.5% - 2% overall speedup on
    `./x264 --threads X --profile high --preset veryfast --crf 15 -o /dev/null park_joy_420_720p50.y4m`
    cabac is responsible for roughly 1/6 of the CPU use.
    Branch mispredictions are reduced by 15% to 20%.
    
    cortex-s53: 0.5% faster
    cortex-a72: 2%  faster
    neoverse-n1: 0.9% faster
commit 9981ea837fe4152c7bd74fe1a4621806481bb71e
Author: Janne Grunau <janne-x264@jannau.net>
Date:   Thu Oct 1 22:15:18 2020 +0200

    aarch64/asm: support offsets in movrel macro
    
    Imported from dav1d.

commit 8578bd9f7f7db61bd1e472a6d6ab21b6e8704740
Author: Janne Grunau <janne-x264@jannau.net>
Date:   Fri Oct 2 01:49:53 2020 +0200

    aarch64/asm: optimize cabac_encode_terminal with extrinsic knowledge
    
    Approach taken from x86 asm. Overall speedup meaningless.
    cabac_encode_terminal on average twice as fast on cortex-53 while
    encoding with following command:
    ./x264 --threads 1 --profile high --preset veryfast --crf 15 -o /dev/null park_joy_420_720p50.y4m
    
    Less relative speedup on cortex-a72/73.

commit 4121277b40a667665d4eea1726aefdc55d12d110
Author: Martin Storsjö <martin@martin.st>
Date:   Mon Oct 26 09:42:20 2020 +0200

    Add a missing include of stdlib.h
    
    Since 7ab4c928ef4511ea5753a36a57c3506d9fd5086b, osdep.h contains
    calls to malloc/free.
    
    This fixes building with MSVC targeting WinRT.
commit 1086f4504e0cc79f04018244428821e18d5d31d8
Author: Damiano Galassi <damiog@gmail.com>
Date:   Thu Jul 23 17:23:09 2020 +0200

    configure: Add Apple Silicon support

commit be3c1492db255a3b3db7196eae0abe804d094985
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Thu Oct 8 21:16:53 2020 +0300

    x86: Remove workaround for nasm on macho64

commit 58dcf16f1bf0fb56d1c75b6b21182120b53d22b4
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Sat Sep 19 13:30:28 2020 +0300

    x86: Fix exhaustive search ME asm

commit 37329c4f103327b6d306c8148c79d9658419231b
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Tue Sep 8 16:36:24 2020 +0300

    x86: Fix memory operands for inline asm

commit f15ee064959c6edd806249c13c886502602919a4
Author: Anton Mitrofanov <BugMaster@narod.ru>
Date:   Fri Sep 4 18:00:45 2020 +0300

    x86: Fix clobbers for inline asm

commit 7ab4c928ef4511ea5753a36a57c3506d9fd5086b
Author: Henrik Gramner <henrik@gramner.com>
Date:   Sat Sep 12 19:24:00 2020 +0200

    Add support for long filenames on Windows 10
commit d198931a63049db1f2c92d96c34904c69fde8117
Author: Henrik Gramner <henrik@gramner.com>
Date:   Sat Sep 12 19:23:57 2020 +0200

    mp4: Remove GPAC Windows Unicode compatibility shim
    
    GPAC has native UTF-8 support nowadays.
    
    Also move the compatibility code to input/avs.c since that's the only
    remaining code that uses it now.

commit 2726e45d4abff3bf005e4a6504c21a7345376680
Author: Henrik Gramner <henrik@gramner.com>
Date:   Sat Sep 12 19:23:55 2020 +0200

    mp4: Fix compiling with recent GPAC versions

Testing this version in xine, parole and vlc shows results are no worse than the previous version ;-) By that I mean that with any of the m4a, mkv, mov, mp4 files I possess there are some which crash the browser, and others where audio is either silent or just random noise (the audio only seems to be a problem in xine). Xine is particularly prone to crashing, but that is not a new development. VLC and parole only crash rarely. Accordingly, I say this version of X264 is "good enough".

Makes me wonder if building Xine is still worthwhile - it used to have better-sounding audio than parole (which uses gstreamer).

comment:2 by Douglas R. Reno, 5 months ago

Can you give me a sample file? I'm curious as to what it's crashing on...

xine-lib is usable in OpenCV and liba52 as well I think, not really sure what it's used for though

in reply to:  2 comment:3 by ken@…, 5 months ago

Replying to renodr:

Can you give me a sample file? I'm curious as to what it's crashing on...

xine-lib is usable in OpenCV and liba52 as well I think, not really sure what it's used for though

I don't recall which purchased files crashed any of them, and anyway they are generally far too large to upload. A quick review of the smaller mp4, mkv files I have that are probably shareable (you-tube downloads) didn't find any that crash any of them. My own camera's mov files continue to crash xine (but ok in parole, vlc), I have a 6 second 25MB mov (steam train waiting to depart, until I realised it was not close to setting off) I can share for testing, contact me privately if you want it.

I will note here that one of my old (2011) mp4 conversions of my own mov files, which mediainfo says was written by x264 core 115 files (less than 21s, 14M instead of the 77M mov) plays ok in current xine on at-video r600, ISTR that too crashed xine - at least on intel - at some past time. That is also available for testing if anyone wants it.

comment:4 by ken@…, 5 months ago

Description: modified (diff)
Summary: X264-20210210X264-20210211

comment:5 by ken@…, 5 months ago

Resolution: fixed
Status: assignedclosed

Uploaded to anduin. Book updated at r24230.

Note: See TracTickets for help on using tickets.