ncftp fails to build with GCC-13 and Clang-16

[Douglas R. Reno]

When building ncftp, I get the following output:

In file included from SAccept.c:1:
  In file included from /sources/ncftp-3.2.6-src/ncftp-3.2.6/sio/syshdrs.h:108:
  
  In file included from /usr/include/signal.h:32:
  /usr/include/bits/types/sig_atomic_t.h:8:24: error: cannot combine with previ
  ous 'type-name' declaration specifier
  typedef __sig_atomic_t sig_atomic_t;
                         ^
  /sources/ncftp-3.2.6-src/ncftp-3.2.6/config.h:174:22: note: expanded from mac
  ro 'sig_atomic_t'
  #define sig_atomic_t int
                       ^
  SAccept.c:47:28: warning: incompatible pointer types passing 'int *' to param
  eter of type 'fd_set *' [-Wincompatible-pointer-types]
                  result = select(sfd + 1, SELECT_TYPE_ARG234 &ss, NULL, NULL, 
  SELECT_TYPE_ARG5 &tv);
                                           ^~~~~~~~~~~~~~~~~~~~~~
  /sources/ncftp-3.2.6-src/ncftp-3.2.6/config.h:156:28: note: expanded from mac
  ro 'SELECT_TYPE_ARG234'
  #define SELECT_TYPE_ARG234 (int *)
                             ^
  /usr/include/sys/select.h:102:51: note: passing argument to parameter '__read
  fds' here
  extern int select (int __nfds, fd_set *__restrict __readfds,
                                                    ^
  1 warning and 1 error generated.
make[1]: *** [Makefile:117: SAccept.o] Error 1
make[1]: Leaving directory '/sources/ncftp-3.2.6-src/ncftp-3.2.6/sio'
make: *** [Makefile:34: libs] Error 2

This appears to be due to the configure script not detecting headers correctly. After some initial investigation, it appears that it's due to the header changes from gcc-13/clang-16, where implicit declarations are no longer allowed.

I've found a patch from Gentoo and Fedora that I will use to fix it and have confirmed that it works.

[Douglas R. Reno]

Fixed at c1e25d1854f6d787fc917110efcd8f6fc0d93809

[Bruce Dubbs]

Milestone renamed