#18206 closed enhancement (fixed)
gegl-0.4.46
Reported by: | Douglas R. Reno | Owned by: | Douglas R. Reno |
---|---|---|---|
Priority: | normal | Milestone: | 12.0 |
Component: | BOOK | Version: | git |
Severity: | normal | Keywords: | |
Cc: |
Description ¶
New point version
Change History (8)
by , 21 months ago
Attachment: | gegl.patch added |
---|
comment:2 by , 21 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:3 by , 21 months ago
Hi Rahul,
Your patch looks good, I'll verify a couple of things here and then drop it in!
comment:4 by , 21 months ago
GEGL-0.4.46 2023-06-26 Core: New simpler API for connecting pads, gegl_node_connect which can be used instead of either gegl_node_connect_from or gegl_node_connect_to by autosensing the neccesary direction of the connection. Operations: GIMP has now started looking at the "gimp:menu-path" key among the GEGL operation class key/value pairs, and putting operations in the corresponding menu. local-threshold: new operation that does neighborhood aware and optionally antialiased thresholding of an image. The operation is equivalent to doing an unsharp mask with a large radius, followed by scaling the image up applying threshold and scaling down by the inverse of the scale up factor. chamfer: new operation in workshop that useis distance-transform and emboss or LinuxBeaver’s research into modeling different bevels with combinations of blurs. ff-load,ff-save: clean up of deprecated API, builds with ffmpeg-6.0 but ff-save hasn’t been made to work with this release of ffmpeg yet. Updated vendored libraries ctx and libnsgif have been updated from upstream. Build: Depend on meson 0.55.0 various cleanups including re-enabling of deprecation warnings. make ctx be an internal library.
It looks like there's some fixes here for ffmpeg compatibility which is very nice to see
comment:5 by , 21 months ago
I do agree with your space figures and timing figures as well:
172.0 Elasped Time - gegl-0.4.46 SBU=1.255 5664 /sources/gegl-0.4.46.tar.xz size (5.531 MB) 108740 kilobytes build size (106.191 MB) md5sum : 241bde22f9204515121e5fb03a2b9fbd /sources/gegl-0.4.46.tar.xz sha1sum: 4df0f3dc59b48272d717bc7758e45046d307cb86 /sources/gegl-0.4.46.tar.xz
This was at -j4 with tests included, so I suspect your 0.9 is correct.
One thing you should always do when updating the book is run tests for the given package. In this case, we'll get:
Summary of Failures: 240/253 gegl:ff-load-save / mpeg4_128kb_avi FAIL 0.45s killed by signal 11 SIGSEGV 242/253 gegl:ff-load-save / mpeg4_512kb_avi FAIL 0.42s killed by signal 11 SIGSEGV 244/253 gegl:ff-load-save / 512kb_mp4 FAIL 1.80s killed by signal 11 SIGSEGV 246/253 gegl:ff-load-save / 128kb_mp4 FAIL 1.62s killed by signal 11 SIGSEGV 248/253 gegl:ff-load-save / 128kb_12fps_mp4 FAIL 1.80s killed by signal 11 SIGSEGV 250/253 gegl:ff-load-save / 128kb_100fps_mp4 FAIL 1.06s killed by signal 11 SIGSEGV 252/253 gegl:ff-load-save / 512kb_28fps_ogv FAIL 0.81s killed by signal 11 SIGSEGV Ok: 114 Expected Fail: 0 Fail: 7 Unexpected Pass: 0 Skipped: 132 Timeout: 0
Looking at the release notes though in the preceding comment, this makes sense since the ff-save command has not been updated to handle ffmpeg-6.0 yet. Maybe the next release, but we need to edit the book to say that 7 tests fail in the gegl:ff-load-save portion of the test suite. I can take care of that though
For further testing of gegl, I always go run GIMP, since GIMP is the primary consumer of gegl. When updating gegl, GIMP will reinitalize a few plugins, and if it launches without error then gegl is pretty much good to go.
comment:6 by , 21 months ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Builds fine on a clean system. However, even with my best attempts I could not replicate the large 131 MB build size or the 1.6 SBU build time on 0.4.44 or 0.4.46, it was always in the neighborhood of 103-105 MB and .8-.9 SBU's (with parallelism=4).
Even enabling luajit gtk-doc and libnsgif (2 of which are not in the BLFS book) only got it to around 121 MB.
Nevertheless, here is a patch.