rustc-1.84.0

[zeckma]

New minor version.

[Xi Ruoyao]

Mine but I'll wait for several days for LLVM-19.1.7 release (scheduled on Jan 14) so I don't need to test everything twice.

[Rahul Chandra]

Seems like they're some stale git connection in the src tarball. The build fails for me with a git fatal error about not a git repo

[Rahul Chandra]

seems to be from this file? src/gcc/libgo/go/cmd/go/testdata/script/get_update_unknown_protocol.txt:exec

git config --local url.https://github.com/.insteadOf xyz://github.com/

[Rahul Chandra]

nevermind spits out the same error even with the file deleted

[Rahul Chandra]

Okay so it wants the main rust git directory in order to try and get a revision number? Maybe the detection for the distribution tarball is turned off? I seriously doubt they shipped a broken tarball.

called Result::unwrap() on an Err value: "command did not execute successfully: cd \"/blfs/builds/rustc-1.84.0-src\" && \"git\" \"rev-list\" \"--author=bors@…\" \"-n1\" \"--first-parent\" \"HEAD\"\nexpected success, got: exit status: 128\n"

[Rahul Chandra]

Think it might have something to do with src/bootstrap/src/core/config/config.rs

(weird file path)

[Rahul Chandra]

You need to add profile="dist" to the top of the config.toml

[Xi Ruoyao]

Replying to Rahul Chandra:

You need to add profile="dist" to the top of the config.toml

It looks like we actually want the setting download-rustc = false in src/bootstrap/defaults/config.dist.toml. profile = "dist" just imports everything from the config.dist.toml file. Well but to me it seems a good idea to use profile = "dist" to simplify our config.toml anyway.

[Xi Ruoyao]

Oops, profile = "dist" imports lld = true and llvm-bitcode-linker = true those we don't want. Even if we want a faster linker we should build lld separately or as a part of LLVM, and I prefer mold anyway (if it didn't need cmake I'd propose it for LFS).

[Xi Ruoyao]

FTR download-rustc = "if-unchanged" is now the default, meaning if we are hacking rustc but we've not modified any compiler components (i.e. we only modified std or cargo), the building system will download those components from upstream CI instead of building them. Checking if any compiler component is modified and getting the correct commit revision for which the CI output to be used obviously need a Git repository, and we want to build everything from source anyway, thus we should change it to download-rustc = false. profile = "dist" just imports download-rustc = false from the src/bootstrap/defaults/config.dist.toml file.

Arguably this option should be named download-ci-rustc instead (as it's similar to the existing download-ci-llvm).

[Rahul Chandra]

Replying to Xi Ruoyao:

Oops, profile = "dist" imports lld = true and llvm-bitcode-linker = true those we don't want. Even if we want a faster linker we should build lld separately or as a part of LLVM, and I prefer mold anyway (if it didn't need cmake I'd propose it for LFS).

Oops I didn't realize that. Weirdly it seemed to build fine anyways? But I think the download-rustc option is probably the best way to go about it. Great catch!

Looking at mold I'm tempted to try it...

[Xi Ruoyao]

Replying to Rahul Chandra:

Replying to Xi Ruoyao:

Oops, profile = "dist" imports lld = true and llvm-bitcode-linker = true those we don't want. Even if we want a faster linker we should build lld separately or as a part of LLVM, and I prefer mold anyway (if it didn't need cmake I'd propose it for LFS).

Oops I didn't realize that. Weirdly it seemed to build fine anyways? But I think the download-rustc option is probably the best way to go about it. Great catch!

It'll build lld and llvm-bitcode-linker from the shipped LLVM source, you'll see some cmake output for them but yes the build should success.

[Xi Ruoyao]

Release note at ​https://blog.rust-lang.org/2025/01/09/Rust-1.84.0.html.

[Xi Ruoyao]

Fixed:

• e289396f0e Update to cbindgen-0.28.0
• ba6b52d6f9 Update to libclc-19.1.7
• c51d4fa6d8 Update to cargo-c-0.10.8
• e4f0942f7f Update to rustc-1.84.0
• 78d53ea52b Update to LLVM-19.1.7