Opened 3 months ago

Closed 2 months ago

#20995 closed enhancement (fixed)

rustc-1.84.1

Reported by: Bruce Dubbs Owned by: Xi Ruoyao
Priority: normal Milestone: 12.3
Component: BOOK Version: git
Severity: normal Keywords:
Cc:

Description

New point version.

Change History (6)

comment:1 by Xi Ruoyao, 2 months ago

Owner: changed from blfs-book to Xi Ruoyao
Status: new → assigned

comment:2 by Xi Ruoyao, 2 months ago

1.84.1 resolves a few regressions introduced in 1.84.0:

  • Fix ICE 132920 in duplicate-crate diagnostics.
  • Fix errors for overlapping impls in incremental rebuilds.
  • Fix slow compilation related to the next-generation trait solver.
  • Fix debuginfo when LLVM's location discriminator value limit is exceeded.

It also includes several fixes for those building Rust from source:

  • Only try to distribute llvm-objcopy if LLVM tools are enabled.
  • Add Profile Override for Non-Git Sources.
  • Resolve symlinks of LLVM tool binaries before copying them.
  • Make it possible to use ci-rustc on tarball sources.

in reply to:  2 ; comment:3 by Xi Ruoyao, 2 months ago

Replying to Xi Ruoyao:

  • Add Profile Override for Non-Git Sources.

This change has made profile = 'dist' the default. As we've discussed in #20897 it contains some things we don't want :(.

Last edited 2 months ago by Xi Ruoyao (previous) (diff)

in reply to:  3 ; comment:4 by Xi Ruoyao, 2 months ago

Replying to Xi Ruoyao:

Replying to Xi Ruoyao:

  • Add Profile Override for Non-Git Sources.

This change has made profile = 'dist' the default. As we've discussed in #20897 it contains some things we don't want :(.

It seems not true.

in reply to:  4 comment:5 by Xi Ruoyao, 2 months ago

Replying to Xi Ruoyao:

Replying to Xi Ruoyao:

Replying to Xi Ruoyao:

  • Add Profile Override for Non-Git Sources.

This change has made profile = 'dist' the default. As we've discussed in #20897 it contains some things we don't want :(.

It seems not true.

I'm asking via ​https://github.com/rust-lang/rust/issues/135358#issuecomment-2627179672.

comment:6 by Xi Ruoyao, 2 months ago

Resolution: → fixed
Status: assigned → closed

Fixed at r12.2-1166-gff585626ab. I've observed no positive nor negative effect of the change mentioned above, thus it seems just ineffective. How to (and should they) make it effective is the business of the upstream, not us.

Note: See TracTickets for help on using tickets.