libaom still fails to configure with nasm-3.01

[zeckma]

Without YASM, NASM-3.01 causes libaom to fail to configure. I mentioned previously that this was because NASM-3 changed the way help information was given which AOM uses. With NASM-3, it requires 2 runs of NASM with different options to give AOM what it needs. Otherwise, AOM fails to configure. NASM-3.01 did NOT fix the issue.

[zeckma]

Fixes libaom configuration with nasm-3.01

[zeckma]

The patch above fixes the configuration issue. What it does is runs nasm -hf, outputs it to $nasm_hf, runs nasm -hO, outputs it to $nasm_ho, then sets $nasm_helptext as $nasm_hf;$nasm_ho so the outputs are combined, giving libaom every bit of info it needs for the configuration process.

[Joe Locash]

Confirmed the issue and that the proposed patch fixes it.

[Joe Locash]

Upstream fix: ​https://aomedia.googlesource.com/aom/+/6d2b7f71b98bfa28e372b1f2d85f137280bdb3de%5E%21/#F0

[zeckma]

The upstream fix basically does the same thing, but only makes -hO part of nasm_helptext, then does an extra check for -hf later on. The upstream fix should do the trick!

[Bruce Dubbs]

Replying to zeckma:

The upstream fix basically does the same thing, but only makes -hO part of nasm_helptext, then does an extra check for -hf later on. The upstream fix should do the trick!

Zeckma, Would you like me to do this? Looking at the link above I think I can do it with a sed.

[zeckma]

I can take care of this one, especially since I have two systems that are affected by this so it's much easier to test this situation.

[zeckma]

Fixed at 852a6652b4bfc898bfc19386b025992d6ffa5541. Sorry for the long delay.

[Bruce Dubbs]

Milestone renamed