Opened 18 years ago
Closed 18 years ago
#2243 closed defect (fixed)
Vorbiscomment 1.1.1
| Reported by: | Ag. Hatzimanikas | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 6.2.0 |
| Component: | BOOK | Version: | SVN |
| Severity: | normal | Keywords: | vorbiscomment |
| Cc: |
Description ¶
Vorbiscomment 1.1.1 can't handle utf-8 characters correctly in UTF-8 locale.
See some comments from a greek song. Greek characters replaced by #.
vorbiscomment -l Φαλλού_πομπή.ogg title= ###### ##### artist= Morel genre= unknown(255) date= album= ######### #### - ### & ###
Please also see this (1) ticket for the issue.
The patch that fixes the bug is attached.
Change History (8)
by , 18 years ago
| Attachment: | vorbis-tools-1.1.1-utf8.patch added |
|---|
comment:1 by , 18 years ago
| Severity: | blocker → normal |
|---|
comment:2 by , 18 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
Randy, this patch is totally safe. All autotooled projects always include config.h in the source files. If I can get it in before the release, can I commit it?
comment:3 by , 18 years ago
Sure. I don't/won't have time to test, that's why I deferred it. If you have time to add it to trunk and merge to the branch, go for it. But whatever you do, make sure you give Ag credit for bringing up the issue and providing a link to the patch. :-)
comment:4 by , 18 years ago
Fine by me either way,although I would like to see it in the book. So,thanks Dan,I appreciate it.
And the inevitable question.
I was ready to say (before Dan's comment),that I could add the info to the wiki.
But why the wiki? Couldn't we just point to this ticket from the book?I hate wikis.
As for the glory joke,both from you,I don't buy that crap.Although I have to agree that for a second I ...feel... well,let's just say...hmmm ...Ok I like it (I just said it).Are you happy now?
comment:5 by , 18 years ago
Hey, you're actively contributing to the book. That deserves to be noted in some way like my name being on the Credits page, or whatever. But if you'd really prefer not to be acknowledged, I can leave it out.
comment:6 by , 18 years ago
<of topic> Dan,do you want to know for what I really care? To see this project stays alive and getting stronger.
I would to be possible for my kids when they will get older a.to be able to build their own system. b.to find the desired information for education,free and available.
If however they will find their father's name in the Changelogs of some old releases,maybe will be a plus and a thing to be proud for-yes I admit it-but it's not _In Any Way- the reason I am contributing in the project.
So do whatever feel better for you,I will not speak again for this issue. </of topic>
For 6.2.0 it might be best to simply make a caution tag and some accompanying text explaining the UTF breakage and point to the Wiki where the patch and help can be found.
Downgrading, as a UTF-8 issue is not a blocker to the release.