Cannot download vim spellfiles via HTTP

[alexander@…]

To reproduce, add these lines to /etc/vimrc:

" I am behind a firewall that doesn't permit ftp
let g:spellfile_url = 'http://ftp.vim.org/vim/runtime/spell'
set spelllang=en,ru

Then, in vim, type:

:set spell

It will ask about downloading a spellfile. If you answer "yes", it will invoke wget with bad options.

The curlpit is ​ftp://ftp.vim.org/pub/vim/patches/7.0/7.0.010, I suggest reverting this patch. To address the password problem that the patch is trying to solve, change the default FTP URL in vim7.0/runtime/autoload/spellfile.vim to the above HTTP URL. Of course, this will introduce a dependency on wget, but we can document that or even add wget to LFS.

[alexander@…]

Upstream author notified

[alexander@…]

The fix

[alexander@…]

Better fix attached. The default is still FTP (thus, it works in bare LFS), but HTTP is now not broken. This fix is also sent to author.

[alexander@…]

Response from Bram Moolenaar:

Your first remark puzzled me, but seeing the patch I understand your problem. I'll put it in the todo list. Thanks for fixing this problem!

[bdubbs@…]

The comments above are confusing.

At 07/25/06 07:51:01

"The fix"

66 seconds later at 07/25/06 07:52:07

"Better fix attached."

The patch is dated as 07/25/06 07:51:01

Is this the correct patch to use? Also, I understand that this is in addition to the other "official" vim patches, correct?

[alexander@…]

Sorry for the confision. The initial suggestion was to revert the 010 official patch and change the default download URL to HTTP. At 07/25/06 07:51:01 a better fix was attached that has to be applied on top of official patches. But Trac doesn't pass announcements of attachments to the mailing list, so I have to add a regular comment.

So: use vim-7.0-spellfile-1.patch on top of the official patch.

[Ag. Hatzimanikas]

The patch would be rejected if you apply it first (maybe a note in the book?.However I would prefer a more general rule in the Books instead of a special note-sorry if it exists already-something like... Apply the patches in the order that appears in the Book,or something like that). Either that or I have prepared a patch that includes Alexander's patch,plus all the known patches so far,3 more than the vim-7.0-fixes-7.patch we currently use. I will attach the patch for review and Alexander's agreement of course.

[bdubbs@…]

Added the patch to 6.2 at version 7725.