Opened 16 years ago

Closed 16 years ago

#2344 closed defect (fixed)

Tar Revert Pipe Drain Patch

Reported by: willimmn Owned by: lfs-book@…
Priority: normal Milestone: 7.0
Component: Book Version: SVN
Severity: normal Keywords:
Cc:

Description

CLFS is using two other Tar patches that apply for 1.21.

The first one, tar-1.21-manpage-1.patch, just makes a Tar manpage, and I don't think LFS will use it anyday.

The second one, tar-1.21-revert_pipe_drain-1.patch, is a patch that is considered to be in LFS. Why? As a example with unpatched Tar 1.21, download this example tarball: (of Glibmm, BTW)

ftp://ftp.gnome.org/pub/gnome/sources/glibmm/2.18/glibmm-2.18.1.tar.bz2

And try to unpack it by running this command:

bzip2 -dc glibmm-2.18.1.tar.bz2 | tar xof -

Tar runs with no error, however, run strace and you will get this output:

write(1, "glibmm-2.18.1/\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = -1 
EPIPE (Broken pipe)
--- SIGPIPE (Broken pipe) @ 0 (0) ---
+++ killed by SIGPIPE +++

Look at this output closly and you will see that bzip2 acualy died because of a broken pipe. Now you see why this patch is a good idea for LFS? It is attached with this ticket.

Attachments (1)

tar-1.21-revert_pipe_drain-1.patch (3.2 KB ) - added by willimmn 16 years ago.
Tar Revert Pipe Drain Path, CLFS version.

Download all attachments as: .zip

Change History (2)

by willimmn, 16 years ago

Tar Revert Pipe Drain Path, CLFS version.

comment:1 by Matthew Burgess, 16 years ago

Resolution: fixed
Status: newclosed
Type: taskdefect

Thanks to Trent Shea for the prompt, using tar-1.22 this works as expected, so no patch is required.

Note: See TracTickets for help on using tickets.