Opened 22 years ago

Closed 22 years ago

Last modified 22 years ago

#268 closed defect (fixed)

few bootscript cleanups

Reported by: gerard@… Owned by: gerard@…
Priority: highest Milestone:
Component: Book Version: CVS
Severity: normal Keywords:
Cc:

Description

  • functions script: set umask 022, and set PATH to /bin:/sbin:/usr/bin:/usr/sbin
  • every script should source the functions script. Even the simple halt and

reboot ones. This will ensure $PATH is set properly and doesn't include 'bad dirs' where other binaries could live called reboot but don't do what we expect it to do.

Change History (9)

comment:1 by gerard@…, 22 years ago

checkfs script bug:

echo -n "Mounting root file system in read-only mode..." mount -n -o remount,ro / evaluate_retval

if [ $? != 0 ] then

$FAILURE

the mount ro mode check should return a value in a seperate variable, so we check it later and print an error. if [ $? != 0 ] will check if the 'echo' command from evaluate_retval executed properly.

comment:2 by gerard@…, 22 years ago

remove full paths from commands used in scripts

comment:3 by gerard@…, 22 years ago

missing Kxxlocalnet in rc0.d and rc6.d

comment:4 by gerard@…, 22 years ago

network stop): instead of the grep for 0.0.0.0 in route output, just check for an existing GATEWAY variable like done with network start)

comment:5 by gerard@…, 22 years ago

fix mountfs and checkfs scripts now that /etc/mtab is a symlink (we don't want to run echo > /etc/mtab && mount -f .... anymore)

comment:6 by gerard@…, 22 years ago

Owner: changed from lfs-book@… to gerard@…
Status: newassigned

comment:7 by gerard@…, 22 years ago

Resolution: fixed
Status: assignedclosed

updating+uploading lfs-bootscripts-1.3 in a minute

comment:8 by markh@…, 22 years ago

Keywords: VERIFIED added

the following were checked in lfs-bootscripts-1.6

==> functions: set umask 022, and PATH to /bin:/sbin:/usr/bin:/usr/sbin confirmed

==> source functions in every script confirmed

==> checkfs: mount ro mode check should return a value in a seperate variable confirmed

==> remove full paths from commands used in all scripts confirmed

==> missing Kxxlocalnet in rc0.d and rc6.d confirmed that they're there now (as K90localnet)

==> just check for an existing GATEWAY variable for default route delete confirmed as part of resolving bug 267

==> mountfs and checkfs: don't want to run echo > /etc/mtab && mount -f confirmed that it's been removed

phew. that's it :-) Verifying

comment:9 by markh@…, 22 years ago

Keywords: VERIFIED removed
Note: See TracTickets for help on using tickets.