Change History (14)
comment:1 by , 22 years ago
| dependson: | → 30 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
comment:2 by , 22 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:3 by , 22 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Add "-o $PPID" again to the reloadproc functions (along with the code where -o %PPID is located)
comment:4 by , 22 years ago
Check out this email: From: Matthias Benkmann <matthias@…> To: lfs-dev@… Subject: Re: slight bootscript functions problem Date: Sat, 9 Feb 2002 10:47:11 +0100
comment:5 by , 22 years ago
On Fri, 8 Feb 2002 21:26:18 -0500 Gerard Beekmans <gerard@…> wrote:
In regards to -o $PPID, I'll put it back in .
You should put in a comment that explains the -o stuff. Something like this:
#do not kill current shell $$ (obvious reasons) and parent $PPID (in the #restart case this is the same script because restart invokes $0) BTW, As I pointed out already (Subject: issues with the functions script, Sep 15, 2001) the %PPID is redundant. It is the same as $$.
And you should really consider looking at the functions script from new-boot-0.2 (I've attached it for your convenience). My *_proc functions work with psmisc's pidof for instance. They don't (ab)use ps (the switch h is non-standard) to check if a process exists (that's what kill is for) and they have useful stuff like the following #only print pids of processes owned by caller if [ -O /proc/$pid ]; then echo $pid ; fi
which prevents user processes that happen to have the same name as a daemon from being shot down accidentally.
comment:6 by , 22 years ago
Do a lot more testing on command outputs. A lot of cases that cause "An unforseen error took place" can be forseen.
Run a bunch of tests and have pretty much everything fail (missing programs, etc, etc) and try to catch the errors.
comment:7 by , 22 years ago
make K70halt/K70reboot K99halt/K99reboot
Move K10network K20localnet up to one of the last things to be run (K80network K90localnet perhaps)
comment:8 by , 22 years ago
restart don't always work (stems from $0 stop and $0 start not always doing what is expected). This apparenty hapens when the script name in /etc/init.d is the same as the name of a program in $PATH)
comment:9 by , 22 years ago
| Status: | reopened → assigned |
|---|
at least some issues have to be fixed for lfs-3.2 (like the restart peculiarity)
comment:10 by , 22 years ago
All fixed, except for the part to catch more errors when certain files are missing for example. That'll be done after 3.2-rc2
comment:11 by , 22 years ago
| Owner: | changed from to |
|---|---|
| Priority: | normal → high |
| Status: | assigned → new |
comment:12 by , 22 years ago
| Summary: | lfs-bootscripts-1.5 → lfs-bootscripts-1.6 |
|---|
comment:14 by , 22 years ago
| dependson: | 30 |
|---|
See Changelog for changes