Opened 8 months ago

Closed 8 months ago

#4998 closed enhancement (fixed)

stop disabling hashing

Reported by: Xi Ruoyao Owned by: Xi Ruoyao
Priority: normal Milestone: 11.1
Component: Book Version: git
Severity: normal Keywords:
Cc:

Description

The +h option for bash should be unneeded since LFS 10.0. Note that it can't be tested with jhalfs, as jhalfs spwans a new bash instance for each page. I'll run a manual build to test.

Change History (6)

comment:1 by Bruce Dubbs, 8 months ago

I don't know why you want to do this. The only possible advantage of using hashing is to speed up some lookups, but the time saved would be negligible. Not using hashing just gives a bit of assurance that the latest version of a file will be used during the build process.

in reply to:  1 comment:2 by Xi Ruoyao, 8 months ago

Replying to Bruce Dubbs:

The only possible advantage of using hashing is to speed up some lookups, but the time saved would be negligible.

The main reason is: the description for disabling hashing is no longer correct in the book.

Not using hashing just gives a bit of assurance that the latest version of a file will be used during the build process.

In Pierre's method using two utilities with the same name but different location would be a bug.

comment:3 by pierre, 8 months ago

We at least need to change the description, but I'd rather stop disabling hashing: doing something useless is not good from a pedagogical viewpoint. And disabling hashing is useless. I kept disabling it when I made the change to the build because at the time I was not sure it was useless. Now I am sure (but I'd forgotten about it, thanks to Xi Ruoyao for bringing this up).

Last edited 8 months ago by pierre (previous) (diff)

comment:4 by Bruce Dubbs, 8 months ago

To do this we need to change several pages:

chapter08/bash.xml
chapter08/revisedchroot.xml
chapter07/createfiles.xml
chapter07/chroot.xml
chapter04/settingenviron.xml

comment:5 by Xi Ruoyao, 8 months ago

Owner: changed from lfs-book to Xi Ruoyao
Status: newassigned

comment:6 by Xi Ruoyao, 8 months ago

Resolution: fixed
Status: assignedclosed

Fixed for trunk.

Note: See TracTickets for help on using tickets.