Opened 21 years ago
Closed 21 years ago
#704 closed defect (fixed)
Ncurses vsscanf patch unnecessary
| Reported by: | Owned by: | ||
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Book | Version: | CVS |
| Severity: | normal | Keywords: | |
| Cc: |
Description
This patch would appear to be unnecessary. I recall it coming up around the time of plfs integration to apparently silence some warnings. It is part of the ncurses c++ binding which is not that widely used AFAICT. Using "--enable-warnings" for ncurses doesn't enable any warnings for the c++ directory. I therefore manually added "-Wall" to the c++ Makefile. There are no warnings with and without the patch for cursesw.cc. This patch is not part of upstream ncurses dev which is updated approx' once a week. In short, there is no rationale for this patch. Unless a c++ programmer can explain in detail why this patch is needed, I recommend it be dropped soon after 5.0 release.
Change History (2)
comment:1 by , 21 years ago
| Priority: | lowest → normal |
|---|
comment:2 by , 21 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
See the thread starting here:
http://linuxfromscratch.org/pipermail/lfs-dev/2003-November/040334.html
Turns out, the patch makes no difference anyway. Committed fixes. Closing.
Let's get a C++ programmer to comment on this, if we can find one on lfs-dev. Raising to P3 for now, will probably become P2 or P1 soon.